Skip to content

Commit 08ba258

Browse files
Jiawei-ShaoDawn LUCI CQ
authored andcommitted
Print the specific bind group in the error message of APISetBindGroup
Now we can print the label of the bind group in the error message of `APISetBindGroup()` as the issue about the error message formatting has gone. Fixed: 42240188 Change-Id: I5bb28d11bd7b6639a972d6c003d38c095a027fb4 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/206434 Reviewed-by: Corentin Wallez <[email protected]> Commit-Queue: Jiawei Shao <[email protected]>
1 parent 388ff62 commit 08ba258

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/dawn/native/RenderEncoderBase.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -719,11 +719,7 @@ void RenderEncoderBase::APISetBindGroup(uint32_t groupIndexIn,
719719

720720
return {};
721721
},
722-
// TODO(dawn:1190): For unknown reasons formatting this message fails if `group` is used
723-
// as a string value in the message. This despite the exact same code working as
724-
// intended in ComputePassEncoder::APISetBindGroup. Replacing with a static [BindGroup]
725-
// until the reason for the failure can be determined.
726-
"encoding %s.SetBindGroup(%u, [BindGroup], %u, ...).", this, groupIndexIn,
722+
"encoding %s.SetBindGroup(%u, %s, %u, ...).", this, groupIndexIn, group,
727723
dynamicOffsetCount);
728724
}
729725

0 commit comments

Comments
 (0)