Skip to content

Commit 0ae5730

Browse files
greggmansparist
authored andcommitted
Make dawn node functions writable
They are writable in the browser but not in dawn node. This breaks compat in the CTS which works by wrapping requestAdapter to insert `compatibilityMode: true` into the adapter descriptor in src/common/util/navigator_gpu.ts Bug: dawn:2151 Change-Id: Ic8a8f20c770c1a602ed03d07ca19c349be4c859e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/163363 Commit-Queue: Gregg Tavares <[email protected]> Kokoro: Kokoro <[email protected]> Reviewed-by: Ben Clayton <[email protected]>
1 parent d375afb commit 0ae5730

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/dawn/node/interop/WebGPU.cpp.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ Wrappers* Wrappers::instance = nullptr;
151151
InstanceMethod("keys", &W{{$.Name}}::keys),
152152
{{- end}}
153153
{{- range $m := $methods}}
154-
InstanceMethod("{{$m.Name}}", &W{{$.Name}}::{{$m.Name}}),
154+
InstanceMethod("{{$m.Name}}", &W{{$.Name}}::{{$m.Name}}, static_cast<napi_property_attributes>(napi_writable | napi_configurable)),
155155
{{- end}}
156156
{{- range $a := $attributes}}
157157
{{- if not (HasAnnotation $a "SameObject")}}

0 commit comments

Comments
 (0)