Revert "[NTOS:CONFIG] Minor formatting + add a comment about ArcSystem component type normalization."

This reverts commit f4cd3f0.

Author: DistroHopper39B

ntoskrnl/config/cmconfig.c

@@ -37,14 +37,8 @@ CmpInitializeRegistryNode(IN PCONFIGURATION_COMPONENT_DATA CurrentEntry,
     /* Get the component */
     Component = &CurrentEntry->ComponentEntry;
 
-    /*
-     * Normalize system class components to ARC system type.
-     * The NT OS loader already sets the component type to
-     * ArcSystem for ARC-compatible systems, but sets it to
-     * MaximumType for non-ARC-compatible ones.
-     */
-    if (Component->Class == SystemClass)
-        Component->Type = ArcSystem;
+    /* Set system class components to ARC system type */
+    if (Component->Class == SystemClass) Component->Type = ArcSystem;
 
     /* Create a key for the component */
     InitializeObjectAttributes(&ObjectAttributes,
@@ -59,16 +53,15 @@ CmpInitializeRegistryNode(IN PCONFIGURATION_COMPONENT_DATA CurrentEntry,
                          NULL,
                          0,
                          &Disposition);
-    if (!NT_SUCCESS(Status))
-        return Status;
+    if (!NT_SUCCESS(Status)) return Status;
 
     /* Check if this is anything but a system class component */
     if (Component->Class != SystemClass)
     {
         /* Build the sub-component string */
         RtlIntegerToChar(DeviceIndexTable[Component->Type]++,
                          10,
-                         _countof(TempBuffer),
+                         12,
                          TempBuffer);
         RtlInitAnsiString(&TempString, TempBuffer);
 
@@ -235,7 +228,7 @@ CmpSetupConfigurationTree(IN PCONFIGURATION_COMPONENT_DATA CurrentEntry,
                 /* EISA */
                 case EisaAdapter:
                 {
-                    /* Adjust information */
+                    /* Fixup information */
                     Interface = Eisa;
                     Bus = CmpTypeCount[EisaAdapter]++;
                     break;
@@ -244,13 +237,13 @@ CmpSetupConfigurationTree(IN PCONFIGURATION_COMPONENT_DATA CurrentEntry,
                 /* Turbo-channel */
                 case TcAdapter:
                 {
-                    /* Adjust information */
+                    /* Fixup information */
                     Interface = TurboChannel;
                     Bus = CmpTypeCount[TurboChannel]++;
                     break;
                 }
 
-                /* ISA, PCI, etc buses */
+                /* ISA, PCI, etc busses */
                 case MultiFunctionAdapter:
                 {
                     /* Check if we have an  identifier */
@@ -268,7 +261,7 @@ CmpSetupConfigurationTree(IN PCONFIGURATION_COMPONENT_DATA CurrentEntry,
                             }
                         }
 
-                        /* Adjust information */
+                        /* Fix up information */
                         Interface = CmpMultifunctionTypes[i].InterfaceType;
                         Bus = CmpMultifunctionTypes[i].Count++;
                     }
@@ -278,7 +271,7 @@ CmpSetupConfigurationTree(IN PCONFIGURATION_COMPONENT_DATA CurrentEntry,
                 /* SCSI Bus */
                 case ScsiAdapter:
                 {
-                    /* Adjust information */
+                    /* Fix up */
                     Interface = Internal;
                     Bus = CmpTypeCount[ScsiAdapter]++;
                     break;
@@ -303,8 +296,7 @@ CmpSetupConfigurationTree(IN PCONFIGURATION_COMPONENT_DATA CurrentEntry,
                                            Interface,
                                            Bus,
                                            DeviceIndexTable);
-        if (!NT_SUCCESS(Status))
-            return Status;
+        if (!NT_SUCCESS(Status)) return Status;
 
         /* Check for children */
         if (CurrentEntry->Child)
@@ -368,7 +360,7 @@ CmpInitializeHardwareConfiguration(IN PLOADER_PARAMETER_BLOCK LoaderBlock)
         return Status;
     NtClose(KeyHandle);
 
-    /* Nobody should have created this key yet! */
+    /* Nobody should've created this key yet! */
     ASSERT(Disposition == REG_CREATED_NEW_KEY);
 
     /* Setup the key name */
@@ -391,7 +383,7 @@ CmpInitializeHardwareConfiguration(IN PLOADER_PARAMETER_BLOCK LoaderBlock)
     if (!NT_SUCCESS(Status))
         return Status;
 
-    /* Nobody should have created this key yet! */
+    /* Nobody should've created this key yet! */
     ASSERT(Disposition == REG_CREATED_NEW_KEY);
 
     /* Allocate the configuration data buffer */