Skip to content

Commit 5c70b3e

Browse files
authored
refactor: rely on --mount syntax instead of the --volume one (#258)
You can learn more here about the difference: https://docs.docker.com/engine/storage/bind-mounts/. In short: both syntaxes permit to achieve the exact same thing in our context, but the `--mount` is more readable, flexible and future-proof.
1 parent 2ab1dad commit 5c70b3e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docs/user-guide/mkdocs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ echo 'Running MkDocs:'
3333
# Avoid permission issues by running the container with the current user ID and group ID
3434
docker run --rm -p 8000:8000 --name docker-papermc-server-mkdocs \
3535
--user "$(id -u):$(id -g)" \
36-
--volume="${ROOT_PROJECT_DIR}:/run" \
36+
--mount type=bind,source="${ROOT_PROJECT_DIR}",target=/run \
3737
--workdir /run/docs/user-guide \
3838
-e MKDOCS_GIT_COMMITTERS_APIKEY="${GITHUB_TOKEN}" \
3939
docker-papermc-server/mkdocs \

docs/user-guide/requirements/pip-compile/pip-compile.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ rm "${CURRENT_DIR}"/requirements.txt
3131
echo
3232
echo 'Running pip-compile:'
3333
docker run --rm --name docker-papermc-server-pip-compile \
34-
--volume="${CURRENT_DIR}:/run" \
34+
--mount type=bind,source="${CURRENT_DIR}",target=/run \
3535
--workdir /run \
3636
docker-papermc-server/pip-tools \
3737
pip-compile --strip-extras "$@"

0 commit comments

Comments
 (0)