Skip to content

Commit 9eecd64

Browse files
authored
fix: ensure graceful shutdown by forwarding SIGTERM (#100)
1 parent d92b89d commit 9eecd64

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

src/main/docker/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ USER daemon:root
101101
# Minecraft port.
102102
EXPOSE 25565
103103

104-
# TODO: Pre-launch server to pre-download Mojang's server jar for quick startup
105104
ENTRYPOINT ["./start.sh"]
106105

107106
# TODO: healthcheck

src/main/docker/docker-bake.hcl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ variable "IMAGE_VERSION" {
2626
default = "0.0.0"
2727
}
2828

29-
# TODO: customizable annotations (url, documentation, source, authors, vendor, ...)
30-
3129
# ========== FUNCTIONS ========== #
3230

3331
function "tag" {

src/main/docker/runtime/start.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,5 +70,4 @@ echo 'File eula.txt processed'
7070

7171
echo 'PaperMC server ready to start!'
7272

73-
# TODO: ensure that the server replace PID 1 instead of spawning a child process (exec command)
74-
java $JVM_ARGUMENTS -jar "${SCRIPT_DIR}"/papermc-server-*.jar $SERVER_ARGS
73+
exec java $JVM_ARGUMENTS -jar "${SCRIPT_DIR}"/papermc-server-*.jar $SERVER_ARGS

0 commit comments

Comments
 (0)