Add Taskfile, fix lint errors, update to Go 1.24

- Added Taskfile.yml with test, lint, fmt, ci tasks
- Fixed package comment (revive)
- Fixed unused parameter warnings in tests
- Updated go.mod to Go 1.24
- All linters passing, 100% test coverage

Author: ndbroadbent

.golangci.yml

@@ -1,48 +1,124 @@
-linters:
-  enable-all: true
-  disable:
-    # Deprecated linters
-    - exhaustivestruct
-    - golint
-    - ifshort
-    - interfacer
-    - maligned
-    - scopelint
-    - nosnakecase
-    - structcheck
-    - varcheck
-    - deadcode
-
-    # Not needed for library
-    - gochecknoglobals
-    - gomnd
-    - mnd
-    - wrapcheck
-    - exhaustruct
-    - ireturn
-    - varnamelen
-
-linters-settings:
-  lll:
-    line-length: 120
-  funlen:
-    lines: 100
-    statements: 50
-  gocognit:
-    min-complexity: 15
-  cyclop:
-    max-complexity: 15
+# golangci-lint configuration
+# v2.5.0-ready: explicit, stable linter set + v2 formatters
 
-issues:
-  exclude-rules:
-    # Allow long lines in tests
-    - path: _test\.go
-      linters:
-        - lll
-        - funlen
-        - gocognit
-        - cyclop
+version: "2"
 
 run:
   timeout: 5m
   tests: true
+
+# Formatters live here in v2 (not in linters.enable)
+formatters:
+  enable:
+    - gofumpt
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/ndbroadbent/db_cutover_orchestrator
+    gofumpt:
+      extra-rules: true
+      module-path: github.com/ndbroadbent/db_cutover_orchestrator
+
+linters:
+  default: none
+  enable:
+    # Core analysis (default enabled linters)
+    - govet
+    - staticcheck
+    - errcheck
+    - ineffassign
+    - unused
+
+    # Error handling
+    - nilerr
+    - forcetypeassert
+
+    # Code quality
+    - revive
+    - gocritic
+
+    # Bugs/correctness
+    - bodyclose
+    - contextcheck
+    - copyloopvar # v2 replacement for exportloopref
+    - noctx
+
+    # Performance
+    - prealloc
+
+    # Complexity
+    - funlen
+    - gocognit
+    - gocyclo
+
+    # Security / policy
+    - gosec
+    - forbidigo
+    - depguard
+
+    # Style
+    - lll
+
+  exclusions:
+    rules:
+      # Allow longer test functions and some duplication in tests
+      - path: _test\.go
+        linters:
+          - funlen
+          - dupl
+          - forbidigo
+          - gosec
+          - gocognit
+      # Allow fmt.Print* in CLI commands (legitimate stdout output)
+      - path: internal/cmd/
+        linters:
+          - forbidigo
+      # Allow file operations in config and state packages
+      - path: internal/(config|state)/
+        text: "G304.*file inclusion"
+        linters:
+          - gosec
+
+  settings:
+    lll:
+      line-length: 120
+      tab-width: 1
+
+    funlen:
+      lines: 100
+      statements: 50
+
+    gocognit:
+      min-complexity: 15
+
+    gocyclo:
+      min-complexity: 15
+
+    forbidigo:
+      forbid:
+        - pattern: '^fmt\.Print.*'
+          msg: "use proper logging instead of fmt.Print"
+        - pattern: "^panic"
+          msg: "use error returns instead of panic"
+        - pattern: '^time\.Sleep'
+          msg: "use context with timeout instead of time.Sleep"
+      exclude-godoc-examples: true
+      analyze-types: true
+
+    depguard:
+      rules:
+        main:
+          list-mode: lax
+          files: [$all]
+          allow:
+            - $gostd
+            - github.com/ndbroadbent/db_cutover_orchestrator
+          deny:
+            - pkg: io/ioutil$
+              desc: "use io or os instead"
+
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0

Taskfile.yml

@@ -0,0 +1,88 @@
+version: "3"
+
+tasks:
+  default:
+    desc: Show available tasks
+    cmds:
+      - task --list
+
+  test:
+    desc: Run tests
+    cmds:
+      - go test -v -race -coverprofile=coverage.out -covermode=atomic ./...
+
+  test:verbose:
+    desc: Run tests with verbose output
+    cmds:
+      - go test -v -race -coverprofile=coverage.out -covermode=atomic ./...
+
+  test:coverage:
+    desc: Run tests with coverage report
+    deps: [test]
+    cmds:
+      - go tool cover -html=coverage.out -o coverage.html
+      - open coverage.html || xdg-open coverage.html || true
+
+  coverage:
+    desc: Check test coverage percentage (requires 100%)
+    deps: [test]
+    cmds:
+      - |
+        coverage=$(go tool cover -func=coverage.out | grep total | awk '{print $3}' | sed 's/%//')
+        echo "Coverage: $coverage%"
+        if (( $(echo "$coverage < 100" | bc -l) )); then
+          echo "Error: Coverage is below 100%"
+          exit 1
+        fi
+
+  lint:config:
+    desc: Verify golangci-lint configuration
+    cmds:
+      - golangci-lint config verify
+
+  lint:
+    desc: Run linters
+    deps: [lint:config]
+    cmds:
+      - golangci-lint run ./...
+
+  lint:fix:
+    desc: Run linters with auto-fix
+    deps: [lint:config]
+    cmds:
+      - golangci-lint run --fix ./...
+
+  fmt:
+    desc: Format code
+    cmds:
+      - gofumpt -l -w .
+      - goimports -local github.com/DocSpring/orderedmap -w .
+
+  ci:
+    desc: Run all CI checks
+    cmds:
+      - task: lint
+      - task: test
+      - task: coverage
+
+  mod:tidy:
+    desc: Tidy go modules
+    cmds:
+      - go mod tidy
+
+  mod:download:
+    desc: Download go modules
+    cmds:
+      - go mod download
+
+  clean:
+    desc: Clean build artifacts
+    cmds:
+      - rm -f coverage.out coverage.html
+
+  install:tools:
+    desc: Install development tools
+    cmds:
+      - go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
+      - go install mvdan.cc/gofumpt@latest
+      - go install golang.org/x/tools/cmd/goimports@latest

go.mod

@@ -1,3 +1,3 @@
 module github.com/DocSpring/orderedmap
 
-go 1.21
+go 1.24

orderedmap.go

@@ -1,3 +1,6 @@
+// Package orderedmap provides a thread-safe, generic ordered map that maintains insertion order
+// while providing O(1) lookups. Unlike Go's built-in map, OrderedMap iterates in the order items
+// were added, preventing UI flickering and enabling predictable, deterministic behavior.
 package orderedmap
 
 import "sync"

orderedmap_test.go

@@ -237,7 +237,7 @@ func TestOrderedMap_Range_Empty(t *testing.T) {
 	om := NewOrderedMap[string, int]()
 
 	called := false
-	om.Range(func(k string, v int) {
+	om.Range(func(_ string, _ int) {
 		called = true
 	})
 
@@ -278,7 +278,7 @@ func TestOrderedMap_RangeBreak(t *testing.T) {
 
 	var keys []string
 
-	om.RangeBreak(func(k string, v int) bool {
+	om.RangeBreak(func(k string, _ int) bool {
 		keys = append(keys, k)
 		return k != "second" // Stop after second
 	})
@@ -304,7 +304,7 @@ func TestOrderedMap_RangeBreak_NoBreak(t *testing.T) {
 
 	var keys []string
 
-	om.RangeBreak(func(k string, v int) bool {
+	om.RangeBreak(func(k string, _ int) bool {
 		keys = append(keys, k)
 		return true // Never break
 	})
@@ -554,7 +554,7 @@ func TestOrderedMap_Concurrent_RangeWhileModifying(t *testing.T) {
 			defer wg.Done()
 			for i := 0; i < 10; i++ {
 				sum := 0
-				om.Range(func(k, v int) {
+				om.Range(func(_, v int) {
 					sum += v
 				})
 			}