fixed linting issues

Author: ndbroadbent

renamify-vscode/extension/src/cliService.ts

@@ -1,4 +1,4 @@
-import { spawn } from 'node:child_process';
+import { type ChildProcess, spawn } from 'node:child_process';
 import * as fs from 'node:fs';
 import * as path from 'node:path';
 import * as vscode from 'vscode';
@@ -12,9 +12,9 @@ type VersionInfo = {
 };
 
 class CommandMutex {
-  private currentProcess: any = null;
+  private currentProcess: ChildProcess | null = null;
 
-  async acquire(): Promise<void> {
+  acquire(): void {
     // Kill any existing process immediately
     this.killCurrentProcess();
     // No waiting, no queuing - just proceed
@@ -24,7 +24,7 @@ class CommandMutex {
     this.currentProcess = null;
   }
 
-  setCurrentProcess(process: any): void {
+  setCurrentProcess(process: ChildProcess): void {
     this.currentProcess = process;
   }
 
@@ -377,8 +377,8 @@ export class RenamifyCliService {
     }
 
     // Acquire mutex to ensure only one command runs at a time
-    await this.commandMutex.acquire();
-    
+    this.commandMutex.acquire();
+
     try {
       // Check version compatibility before every command (except for version command itself)
       // Skip version check when using mock spawn (in tests)
@@ -389,9 +389,9 @@ export class RenamifyCliService {
       // Try the command, with one retry after 100ms if it fails
       try {
         return await this.executeCliCommand(args);
-      } catch (error) {
+      } catch (_error) {
         // Wait 100ms and retry once
-        await new Promise(resolve => setTimeout(resolve, 100));
+        await new Promise((resolve) => setTimeout(resolve, 100));
         return await this.executeCliCommand(args);
       }
     } finally {

renamify-vscode/extension/src/test/suite/cliService.test.ts

@@ -256,12 +256,12 @@ suite('CLI Service Test Suite', () => {
   test('Should handle CLI errors correctly', async () => {
     // Temporarily restore the original stub to modify it
     sandbox.restore();
-    
+
     // Re-create the stub with mocked-cli-path to skip version check
     sandbox.stub(vscode.workspace, 'getConfiguration').returns({
       get: (key: string) => {
         if (key === 'cliPath') {
-          return 'mocked-cli-path';  // Use special value to skip version check
+          return 'mocked-cli-path'; // Use special value to skip version check
         }
         if (key === 'respectGitignore') {
           return true;
@@ -272,7 +272,7 @@ suite('CLI Service Test Suite', () => {
 
     // Re-create the mock spawn
     mockSpawn = sandbox.stub();
-    
+
     // Create a new CLI service with the updated configuration
     const testCliService = new RenamifyCliService(mockSpawn as any);
 

renamify-vscode/extension/src/webviewProvider.ts

@@ -123,7 +123,7 @@ export class RenamifyViewProvider implements vscode.WebviewViewProvider {
   private async handleSearch(data: SearchMessage) {
     // Kill any running command before starting a new search
     this._cliService.killCurrentCommand();
-    
+
     try {
       let results: SearchResult[];
       let paths: Rename[] = [];
@@ -194,21 +194,25 @@ export class RenamifyViewProvider implements vscode.WebviewViewProvider {
         type: 'searchResults',
         results,
         paths,
-        searchId: (data as any).searchId,
+        searchId: data.searchId,
       });
     } catch (error) {
-      const errorMessage = error instanceof Error ? error.message : String(error);
+      const errorMessage =
+        error instanceof Error ? error.message : String(error);
       console.error('Search failed:', errorMessage);
-      
+
       // Send error to webview to display in results area
       this._view?.webview.postMessage({
         type: 'searchError',
         error: errorMessage,
-        searchId: (data as any).searchId,
+        searchId: data.searchId,
       });
-      
+
       // Show error notification for lock errors or other critical failures
-      if (errorMessage.includes('lock') || errorMessage.includes('Another renamify process')) {
+      if (
+        errorMessage.includes('lock') ||
+        errorMessage.includes('Another renamify process')
+      ) {
         vscode.window.showErrorMessage(`Search failed: ${errorMessage}`);
       }
     }
@@ -217,7 +221,7 @@ export class RenamifyViewProvider implements vscode.WebviewViewProvider {
   private async handlePlan(data: PlanMessage) {
     // Kill any running command before starting a new plan
     this._cliService.killCurrentCommand();
-    
+
     try {
       const plan = await this._cliService.createPlan(
         data.search,
@@ -248,7 +252,7 @@ export class RenamifyViewProvider implements vscode.WebviewViewProvider {
   private async handleApply(data: ApplyMessage) {
     // Kill any running command before starting apply
     this._cliService.killCurrentCommand();
-    
+
     const config = vscode.workspace.getConfiguration('renamify');
 
     // Get current search and replace from the message

renamify-vscode/webview/src/webview.ts

@@ -21,10 +21,9 @@ type SearchResult = {
 
   let currentResults: SearchResult[] = [];
   const expandedFiles = new Set<number>();
-  
+
   // Search state tracking
   let currentSearchId = 0;
-  let isSearching = false;
 
   // DOM elements
   const searchInput = document.getElementById('search') as HTMLInputElement;
@@ -204,7 +203,6 @@ type SearchResult = {
     // Clear results if search is empty
     if (!searchTerm) {
       clearResults();
-      isSearching = false;
       return;
     }
 
@@ -214,13 +212,11 @@ type SearchResult = {
       clearResults();
       resultsTree.innerHTML =
         '<div class="empty-state">Please select at least one case style</div>';
-      isSearching = false;
       return;
     }
 
     // Increment search ID and track this search
     const searchId = ++currentSearchId;
-    isSearching = true;
 
     // Clear previous results and summary immediately when starting new search
     clearResults();
@@ -235,7 +231,7 @@ type SearchResult = {
       exclude: excludeInput.value,
       excludeMatchingLines: excludeLinesInput.value,
       caseStyles: selectedStyles,
-      searchId: searchId, // Include search ID to match responses
+      searchId, // Include search ID to match responses
     });
   }
 
@@ -334,15 +330,15 @@ type SearchResult = {
     expandedFiles.clear();
     resultsSummary.textContent = '';
     openInEditorLink.style.display = 'none';
-    
+
     resultsTree.innerHTML = `<div class="error-state">
       <div class="error-icon">⚠️</div>
       <div class="error-message">
         <strong>Search failed:</strong><br>
         ${escapeHtml(errorMessage)}
       </div>
     </div>`;
-    
+
     updateExpandCollapseButtons();
   }
 
@@ -723,26 +719,22 @@ type SearchResult = {
       case 'searchResults':
         if (message.searchId === currentSearchId) {
           renderResults(message.results, message.paths);
-          isSearching = false;
         }
         break;
       case 'searchError':
         if (message.searchId === currentSearchId) {
           showError(message.error);
-          isSearching = false;
         }
         break;
       case 'clearResults':
         clearResults();
-        isSearching = false;
         break;
       case 'planCreated':
         // Update UI to show plan was created
         break;
       case 'changesApplied':
         // Clear results after successful apply
         clearResults();
-        isSearching = false;
         break;
       default:
         console.warn(`Unknown message type: ${message.type}`);