Merge pull request #181 from DockyardMC/fix/send-system-message

Fix `player.sendSystemMessage` raising `ServerSendPlayerMessageEvent`

Author: LukynkaCZE

src/main/kotlin/io/github/dockyardmc/player/Player.kt

@@ -327,9 +327,11 @@ class Player(
         // this event and the `isSystem` arg is quite literally only for one feature in my other project,
         // but it's my server implementation anyway I can do whatever I want
         // - maya
-        val event = ServerSendPlayerMessageEvent(this, message, isSystem, getPlayerEventContext(this))
-        Events.dispatch(event)
-        if (event.cancelled) return
+        if (!isActionBar) {
+            val event = ServerSendPlayerMessageEvent(this, message, isSystem, getPlayerEventContext(this))
+            Events.dispatch(event)
+            if (event.cancelled) return
+        }
 
         if (networkManager.state != ProtocolState.PLAY) {
             queuedMessages.add(message to isActionBar)

src/test/kotlin/io/github/dockyard/tests/events/ServerSendPlayerMessageEventTest.kt

@@ -33,4 +33,19 @@ class ServerSendPlayerMessageEventTest {
         assertTrue(count.await(5L, TimeUnit.SECONDS))
         pool.dispose()
     }
+
+    @Test
+    fun testEventDoesNotFire() {
+        val pool = EventPool()
+        val count = CountDownLatch(1)
+
+        pool.on<ServerSendPlayerMessageEvent> {
+            count.countDown()
+        }
+        PlayerTestUtil.getOrCreateFakePlayer().sendActionBar("not :3")
+
+        count.await(2L, TimeUnit.SECONDS)
+        assertTrue { count.count == 1L }
+        pool.dispose()
+    }
 }