Skip to content
This repository was archived by the owner on Nov 28, 2025. It is now read-only.

Commit 85fccbe

Browse files
committed
default to showing text in hover events
1 parent 9d48197 commit 85fccbe

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

src/main/kotlin/io/github/dockyardmc/scroll/providers/default/HoverEventProvider.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import io.github.dockyardmc.scroll.providers.FormatProviderContext
99
class HoverEventProvider: ClosingNamedFormatProvider("hover", listOf()) {
1010

1111
override fun formatNormal(context: FormatProviderContext, component: Component) {
12-
component.hoverEvent = when (context.getArgument(0)) {
12+
component.hoverEvent = when (val action = context.getArgument(0)) {
1313
"show_text" -> HoverEvent.ShowText(context.getArgument(1).toComponent())
1414
"show_item" -> HoverEvent.ShowItem(context.getArgument(1), context.getArgumentOrNull(2)?.toIntOrNull() ?: 1)
1515
"show_entity" -> HoverEvent.ShowEntity(context.getArgument(1), context.getArgument(2), context.getArgumentOrNull(3)?.toComponent())
1616

17-
else -> return
17+
else -> HoverEvent.ShowText(action.toComponent())
1818
}
1919
}
2020

src/test/kotlin/StringSerializationTests.kt

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,19 @@ class StringSerializationTests {
148148
assertEquals(expected.toJson(), Scroll.parse(input).toJson())
149149
}
150150

151+
@Test
152+
fun testDefaultHover() {
153+
val input = "<hover:':3'>Hover for colon three"
154+
val expected = Component.compound(mutableListOf(
155+
Component(
156+
text = "Hover for colon three",
157+
hoverEvent = HoverEvent.ShowText(":3")
158+
)
159+
))
160+
161+
assertEquals(expected.toJson(), input.toComponent().toJson())
162+
}
163+
151164
@Test
152165
fun testClickWithLink() {
153166
val input = "<click:open_url:'https://lukynka.cloud'><aqua><underline>https://lukynka.cloud"

0 commit comments

Comments
 (0)