Skip to content

Commit 5b2c2a7

Browse files
Improve test assertion clarity based on code review
Co-authored-by: willtheorangeguy <[email protected]>
1 parent 122e745 commit 5b2c2a7

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

tests/test_main.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -308,11 +308,10 @@ def test_video_command_linux(self, mock_input, mock_print, mock_subprocess):
308308
# On Linux, should attempt to call xdg-open
309309
# Note: The actual call might fail due to invalid path, but we're testing the attempt
310310
printed_output = [str(call) for call in mock_print.call_args_list]
311-
# Video timestamp should be added to output
312-
assert (
313-
any("Video" in str(call) for call in printed_output)
314-
or mock_subprocess.called
315-
)
311+
# Verify video command was processed - either video text printed or subprocess called
312+
video_text_found = any("Video" in str(call) for call in printed_output)
313+
subprocess_was_called = mock_subprocess.called
314+
assert video_text_found or subprocess_was_called, "Video command should print text or call subprocess"
316315

317316

318317
class TestWelcomeScreen:

0 commit comments

Comments
 (0)