Skip to content

Commit 3c008ba

Browse files
authored
chore: Fix npm/node to v6 and latest LTS (#441)
1 parent 6dc59f9 commit 3c008ba

24 files changed

+37
-20
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Feel free to leave unchecked or remove the lines that are not applicable.
1818
- [ ] Updated docs (storybooks, readme)
1919
- [ ] Executed `npm run validate` and made sure no errors / warnings were shown
2020
- [ ] Described changes in `CHANGELOG.md`
21-
- [ ] Bumped version in `package.json`
21+
- [ ] Bumped version in `package.json` and `package-lock.json` (`npm --no-git-tag-version version <major|minor|patch>`) [ref](https://docs.npmjs.com/cli/v6/commands/npm-version)
2222
- [ ] Updated all static build artifacts (`npm run build-all`)
2323

2424
## Versioning

.github/codeql/codeql-config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
paths:
2+
- src

.github/workflows/codeql-analysis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ jobs:
3030
# Initializes the CodeQL tools for scanning.
3131
- name: Initialize CodeQL
3232
uses: github/codeql-action/init@v1
33+
with:
34+
config-file: ./.github/codeql/codeql-config.yml
3335
# Override language selection by uncommenting this and choosing your languages
34-
# with:
3536
# languages: go, javascript, csharp, python, cpp, java
3637

3738
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).

.github/workflows/coverage-reporting.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
- uses: actions/checkout@v2
1414
- uses: actions/setup-node@v1
1515
with:
16-
node-version: 12
16+
node-version: 14
1717
- name: Install dependencies
1818
run: npm set progress=false && CYPRESS_INSTALL_BINARY=0 HUSKY_SKIP_INSTALL=1 npm ci --silent
1919
- name: Run tests and collect coverage

.github/workflows/publish.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
- uses: actions/checkout@v1
1313
- uses: actions/setup-node@v1
1414
with:
15-
node-version: 12
15+
node-version: 14
1616
- run: npm ci
1717
- run: npm run lint
1818
- run: npm run type-check
@@ -24,7 +24,7 @@ jobs:
2424
# Publish to GitHub package registry
2525
- uses: actions/setup-node@v1
2626
with:
27-
node-version: 12
27+
node-version: 14
2828
registry-url: https://npm.pkg.github.com/
2929
scope: '@doist'
3030
- run: npm publish
@@ -34,7 +34,7 @@ jobs:
3434
# Publish to npm registry
3535
- uses: actions/setup-node@v1
3636
with:
37-
node-version: 12
37+
node-version: 14
3838
registry-url: https://registry.npmjs.org/
3939
scope: '@doist'
4040
- run: npm publish

.github/workflows/pull_request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
- uses: actions/checkout@v1
1010
- uses: actions/setup-node@v1
1111
with:
12-
node-version: 12
12+
node-version: 14
1313
- run: npm ci
1414
- run: npm run lint
1515
- run: npm run type-check

.npmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
engine-strict=true

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v14.15.5

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.
44

5+
## 9.0.0
6+
7+
- [Build] The project now requires node v14.5.5+ and npm v6.14.11+ to install and run.
8+
- We're skipping right over v8.0.0 as its tag has already been created previously
9+
510
## 7.2.1
611

712
- [Tweak] Adds `defaultValue` and ensures additional props are carried forward on the `Select` component.

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,17 @@ You can find our changelog [here](./CHANGELOG.md).
4444

4545
# Development
4646

47-
First clone the repository, and run its setup task:
47+
We leverage `package.json`'s `engines` field to specify the node/npm versions to be used while in development. The easiest way to switch quickly is through [fnm](https://github.com/Schniz/fnm).
48+
49+
It's worth noting that fnm can automatically switch to a project's specified node version when it encounters a `.nvmrc` file. To do so, use the `--use-on-cd` flag when [generating your shell's config script with `fnm env`](https://github.com/Schniz/fnm#fnm-env).
50+
51+
Once fnm is installed, clone the repository. Then, switch to the required node version, and run its setup task:
4852

4953
```sh
5054
git clone https://github.com/doist/reactist.git
5155
cd reactist
56+
fnm install
57+
fnm use
5258
npm run setup
5359
```
5460

0 commit comments

Comments
 (0)