Skip to content

Commit 9e3b47a

Browse files
frankieyanfrankieyan
authored
KeyCapturer: Prevent onEnter from firing in the middle of an IME composition session (#223)
* Expose event from KeyCapturer * Rewrite KeyCapturer as a functional component * Prevent onEnter from firing in IME session * Update CHANGELOG for v4.1.0 * Update KeyCapturer docs to mention IME composition * Build storybook artifacts * Bump version to v4.1.0 * Fix KeyCapturerStory filename * Apply new lint rules to KeyCapturer
1 parent 597afd0 commit 9e3b47a

24 files changed

+240
-148
lines changed

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
Reactist follows [semantic versioning](https://semver.org/) and doesn't introduce breaking changes (API-wise) in minor or patch releases. However, the appearance of a component might change in a minor or patch release so keep an eye on redesigns and make sure your app still looks and feels like you expect it.
44

5+
## 4.1.0
6+
7+
- [New] The `event` object is now forwarded to the on* handler in the `KeyCapturer` component. The `onEnter` event will also no longer fire when it's in the middle of an [IME composition session](https://developer.mozilla.org/en-US/docs/Glossary/input_method_editor).
8+
59
## 4.0.2
610

711
- [New] Brings back individual JS and CSS files so that applications can do selective import in an ES6 build.

‎docs/iframe.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,4 @@
7171
}</script><style>#root[hidden],
7272
#docs-root[hidden] {
7373
display: none !important;
74-
}</style></head><body><div class="sb-nopreview sb-wrapper"><div class="sb-nopreview_main"><h1 class="sb-nopreview_heading sb-heading">No Preview</h1><p>Sorry, but you either have no stories or none are selected somehow.</p><ul><li>Please check the Storybook config.</li><li>Try reloading the page.</li></ul><p>If the problem persists, check the browser console, or the terminal you've run Storybook from.</p></div></div><div class="sb-errordisplay sb-wrapper"><pre id="error-message" class="sb-heading"></pre><pre class="sb-errordisplay_code"><code id="error-stack"></code></pre></div><div id="root"></div><div id="docs-root"></div><script src="runtime~main.c81b9c801a9e8907d3c6.bundle.js"></script><script src="vendors~main.c81b9c801a9e8907d3c6.bundle.js"></script><script src="main.c81b9c801a9e8907d3c6.bundle.js"></script></body></html>
74+
}</style></head><body><div class="sb-nopreview sb-wrapper"><div class="sb-nopreview_main"><h1 class="sb-nopreview_heading sb-heading">No Preview</h1><p>Sorry, but you either have no stories or none are selected somehow.</p><ul><li>Please check the Storybook config.</li><li>Try reloading the page.</li></ul><p>If the problem persists, check the browser console, or the terminal you've run Storybook from.</p></div></div><div class="sb-errordisplay sb-wrapper"><pre id="error-message" class="sb-heading"></pre><pre class="sb-errordisplay_code"><code id="error-stack"></code></pre></div><div id="root"></div><div id="docs-root"></div><script src="runtime~main.e51fb259e389d418832f.bundle.js"></script><script src="vendors~main.e51fb259e389d418832f.bundle.js"></script><script src="main.e51fb259e389d418832f.bundle.js"></script></body></html>

‎docs/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@
1616
}</script><style>#root[hidden],
1717
#docs-root[hidden] {
1818
display: none !important;
19-
}</style></head><body><div id="root"></div><div id="docs-root"></div><script>window['DOCS_MODE'] = false;</script><script src="runtime~main.72c61344ec336373a1bf.bundle.js"></script><script src="vendors~main.40632083b01f0b098aeb.bundle.js"></script><script src="main.7b438b75aa6cd51c2e08.bundle.js"></script></body></html>
19+
}</style></head><body><div id="root"></div><div id="docs-root"></div><script>window['DOCS_MODE'] = false;</script><script src="runtime~main.72c61344ec336373a1bf.bundle.js"></script><script src="vendors~main.14c17b74efaab0f95c7c.bundle.js"></script><script src="main.04e95477ccab1a9e1ad2.bundle.js"></script></body></html>

‎docs/main.04e95477ccab1a9e1ad2.bundle.js‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/main.7b438b75aa6cd51c2e08.bundle.js‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎docs/main.c81b9c801a9e8907d3c6.bundle.js‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎docs/main.c81b9c801a9e8907d3c6.bundle.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎docs/main.e51fb259e389d418832f.bundle.js‎

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/main.e51fb259e389d418832f.bundle.js.map‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/runtime~main.c81b9c801a9e8907d3c6.bundle.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)