feat: suppress package manager output during update (#104)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: scottlovegrove

src/__tests__/update.test.ts

@@ -52,6 +52,9 @@ function mockFetchNetworkError(message: string) {
 
 function mockSpawnSuccess() {
     mockSpawn.mockReturnValue({
+        stderr: {
+            on: vi.fn(),
+        },
         on: vi.fn((event: string, cb: (arg?: unknown) => void) => {
             if (event === 'close') cb(0)
         }),
@@ -60,6 +63,9 @@ function mockSpawnSuccess() {
 
 function mockSpawnFailure(exitCode: number) {
     mockSpawn.mockReturnValue({
+        stderr: {
+            on: vi.fn(),
+        },
         on: vi.fn((event: string, cb: (arg?: unknown) => void) => {
             if (event === 'close') cb(exitCode)
         }),
@@ -68,6 +74,9 @@ function mockSpawnFailure(exitCode: number) {
 
 function mockSpawnPermissionError() {
     mockSpawn.mockReturnValue({
+        stderr: {
+            on: vi.fn(),
+        },
         on: vi.fn((event: string, cb: (arg?: unknown) => void) => {
             if (event === 'error') {
                 const err = Object.assign(new Error('EACCES'), { code: 'EACCES' })
@@ -150,7 +159,7 @@ describe('update command', () => {
             expect(mockSpawn).toHaveBeenCalledWith(
                 'npm',
                 ['install', '-g', '@doist/todoist-cli@latest'],
-                { stdio: 'inherit' },
+                { stdio: 'pipe' },
             )
             expect(consoleSpy).toHaveBeenCalledWith(
                 expect.anything(),
@@ -169,7 +178,7 @@ describe('update command', () => {
             expect(mockSpawn).toHaveBeenCalledWith(
                 'pnpm',
                 ['add', '-g', '@doist/todoist-cli@latest'],
-                { stdio: 'inherit' },
+                { stdio: 'pipe' },
             )
         })
     })

src/commands/update.ts

@@ -26,15 +26,20 @@ function detectPackageManager(): string {
     return 'npm'
 }
 
-function runInstall(pm: string): Promise<number> {
+function runInstall(pm: string): Promise<{ exitCode: number; stderr: string }> {
     const command = pm === 'pnpm' ? 'add' : 'install'
     return new Promise((resolve, reject) => {
         const child = spawn(pm, [command, '-g', `${PACKAGE_NAME}@latest`], {
-            stdio: 'inherit',
+            stdio: 'pipe',
+        })
+
+        let stderr = ''
+        child.stderr?.on('data', (data: Buffer) => {
+            stderr += data.toString()
         })
 
         child.on('error', reject)
-        child.on('close', (code) => resolve(code ?? 1))
+        child.on('close', (code) => resolve({ exitCode: code ?? 1, stderr }))
     })
 }
 
@@ -68,15 +73,13 @@ export async function updateAction(options: { check?: boolean }): Promise<void>
     }
 
     const pm = detectPackageManager()
-    console.log(chalk.dim(`Updating to v${latestVersion}...`))
 
+    let result: { exitCode: number; stderr: string }
     try {
-        const exitCode = await runInstall(pm)
-        if (exitCode !== 0) {
-            console.error(chalk.red('Error:'), `${pm} exited with code ${exitCode}`)
-            process.exitCode = 1
-            return
-        }
+        result = await withSpinner(
+            { text: `Updating to v${latestVersion}...`, color: 'blue' },
+            () => runInstall(pm),
+        )
     } catch (error) {
         if (error instanceof Error && 'code' in error && error.code === 'EACCES') {
             console.error(chalk.red('Error:'), 'Permission denied. Try running with sudo:')
@@ -93,6 +96,15 @@ export async function updateAction(options: { check?: boolean }): Promise<void>
         return
     }
 
+    if (result.exitCode !== 0) {
+        console.error(chalk.red('Error:'), `${pm} exited with code ${result.exitCode}`)
+        if (result.stderr) {
+            console.error(chalk.dim(result.stderr.trim()))
+        }
+        process.exitCode = 1
+        return
+    }
+
     console.log(chalk.green('✓'), `Updated to v${latestVersion}`)
 }