Skip to content

Commit 19244a2

Browse files
authored
Merge pull request #3034 from Dokploy/3012-bug-v0256-database-restore-from-s3-gui-fails-due-to-unescaped-special-characters-in-the-database-password
fix: update database restore commands to properly quote user credentials
2 parents 201cc65 + c4c1930 commit 19244a2

File tree

1 file changed

+4
-4
lines changed
  • packages/server/src/utils/restore

1 file changed

+4
-4
lines changed

packages/server/src/utils/restore/utils.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,30 @@ export const getPostgresRestoreCommand = (
77
database: string,
88
databaseUser: string,
99
) => {
10-
return `docker exec -i $CONTAINER_ID sh -c "pg_restore -U ${databaseUser} -d ${database} -O --clean --if-exists"`;
10+
return `docker exec -i $CONTAINER_ID sh -c "pg_restore -U '${databaseUser}' -d ${database} -O --clean --if-exists"`;
1111
};
1212

1313
export const getMariadbRestoreCommand = (
1414
database: string,
1515
databaseUser: string,
1616
databasePassword: string,
1717
) => {
18-
return `docker exec -i $CONTAINER_ID sh -c "mariadb -u ${databaseUser} -p${databasePassword} ${database}"`;
18+
return `docker exec -i $CONTAINER_ID sh -c "mariadb -u '${databaseUser}' -p'${databasePassword}' ${database}"`;
1919
};
2020

2121
export const getMysqlRestoreCommand = (
2222
database: string,
2323
databasePassword: string,
2424
) => {
25-
return `docker exec -i $CONTAINER_ID sh -c "mysql -u root -p${databasePassword} ${database}"`;
25+
return `docker exec -i $CONTAINER_ID sh -c "mysql -u root -p'${databasePassword}' ${database}"`;
2626
};
2727

2828
export const getMongoRestoreCommand = (
2929
database: string,
3030
databaseUser: string,
3131
databasePassword: string,
3232
) => {
33-
return `docker exec -i $CONTAINER_ID sh -c "mongorestore --username ${databaseUser} --password ${databasePassword} --authenticationDatabase admin --db ${database} --archive"`;
33+
return `docker exec -i $CONTAINER_ID sh -c "mongorestore --username '${databaseUser}' --password '${databasePassword}' --authenticationDatabase admin --db ${database} --archive"`;
3434
};
3535

3636
export const getComposeSearchCommand = (

0 commit comments

Comments
 (0)