TDD: Write ReportFileRepository test code

Author: Dokyeongyun

Core/src/main/java/root/core/repository/constracts/ReportRepository.java

@@ -4,10 +4,9 @@
 
 public interface ReportRepository {
 
-	<T> void writeReportFile(String filePath, String fileName, String fileExtension, List<T> monitoringResult,
-			Class<T> clazz);
+	<T> void writeReportFile(String fileName, String fileExtension, List<T> monitoringResult, Class<T> clazz);
 
 	List<String> getReportHeaders(Class<?> monitoringType, String alias);
-	
+
 	String getReportContentsInCsv(Class<?> monitoringType, String alias);
 }

Core/src/main/java/root/core/usecase/implement/DBCheckUsecaseImpl.java

@@ -47,10 +47,9 @@ public void printArchiveUsageCheck() {
 				System.out.println("\t▶ Archive Usage Check : SUCCESS\n");
 			}
 		});
-		
+
 		try {
-			TextTable tt = new TextTable(
-					new CsvTableModel(CsvUtils.toCsvString(result, ArchiveUsage.class)));
+			TextTable tt = new TextTable(new CsvTableModel(CsvUtils.toCsvString(result, ArchiveUsage.class)));
 			tt.printTable(System.out, 8);
 			System.out.println();
 		} catch (IOException e) {
@@ -63,8 +62,7 @@ public void printTableSpaceCheck() {
 		List<TableSpaceUsage> result = dbCheckRepository.checkTableSpaceUsage();
 		System.out.println("\t▶ TableSpace Usage Check");
 		try {
-			TextTable tt = new TextTable(
-					new CsvTableModel(CsvUtils.toCsvString(result, TableSpaceUsage.class)));
+			TextTable tt = new TextTable(new CsvTableModel(CsvUtils.toCsvString(result, TableSpaceUsage.class)));
 			tt.printTable(System.out, 8);
 			System.out.println();
 		} catch (IOException e) {
@@ -77,8 +75,7 @@ public void printASMDiskCheck() {
 		List<ASMDiskUsage> result = dbCheckRepository.checkASMDiskUsage();
 		System.out.println("\t▶ ASM Disk Usage Check");
 		try {
-			TextTable tt = new TextTable(
-					new CsvTableModel(CsvUtils.toCsvString(result, ASMDiskUsage.class)));
+			TextTable tt = new TextTable(new CsvTableModel(CsvUtils.toCsvString(result, ASMDiskUsage.class)));
 			tt.printTable(System.out, 8);
 			System.out.println();
 		} catch (IOException e) {
@@ -110,13 +107,13 @@ public void writeExcelArchiveUsageCheck() throws Exception {
 		String fileName = "DB관리대장_종합_" + year + "." + DateUtils.getTwoDigitDate(month);
 		String extension = ".xlsx";
 		File file = new File(filePath + fileName + extension);
-		
-		if(!file.exists()) {
+
+		if (!file.exists()) {
 			file.getParentFile().mkdirs();
 			DBManageExcel.createMonthlyReportInExcel(year, month);
 		}
-		
-		double archiveUsage = result.get(0).getUsedPercent(); 
+
+		double archiveUsage = result.get(0).getUsedPercent();
 		Workbook workbook = ExcelSheet.getWorkbook(new FileInputStream(file), fileName + extension);
 		Sheet sheet = workbook.getSheetAt(0);
 		sheet.getRow(rowIndex).getCell(colIndex).setCellValue(archiveUsage + "%");
@@ -127,19 +124,19 @@ public void writeExcelArchiveUsageCheck() throws Exception {
 	@Override
 	public void writeCsvArchiveUsage() {
 		List<ArchiveUsage> result = dbCheckRepository.checkArchiveUsage();
-		reportRepository.writeReportFile("ArchiveUsage", dbCheckRepository.getDBName(), ".txt", result, ArchiveUsage.class);
+		reportRepository.writeReportFile(dbCheckRepository.getDBName(), ".txt", result, ArchiveUsage.class);
 	}
 
 	@Override
 	public void writeCsvTableSpaceUsage() {
 		List<TableSpaceUsage> result = dbCheckRepository.checkTableSpaceUsage();
-		reportRepository.writeReportFile("TableSpaceUsage", dbCheckRepository.getDBName(), ".txt", result, TableSpaceUsage.class);
+		reportRepository.writeReportFile(dbCheckRepository.getDBName(), ".txt", result, TableSpaceUsage.class);
 	}
 
 	@Override
 	public void writeCsvASMDiskUsage() {
 		List<ASMDiskUsage> result = dbCheckRepository.checkASMDiskUsage();
-		reportRepository.writeReportFile("ASMDiskUsage", dbCheckRepository.getDBName(), ".txt", result, ASMDiskUsage.class);
+		reportRepository.writeReportFile(dbCheckRepository.getDBName(), ".txt", result, ASMDiskUsage.class);
 	}
 
 	@Override

Core/src/main/java/root/core/usecase/implement/ServerMonitoringUsecaseImpl.java

@@ -257,8 +257,7 @@ public void writeCsvOSDiskUsage() throws Exception {
 			os.setMonitoringDate(monitoringDate);
 			os.setMonitoringTime(monitoringTime);
 		}
-		reportRepository.writeReportFile("OSDiskUsage", serverCheckRepository.getServerName(), ".txt", result,
-				OSDiskUsage.class);
+		reportRepository.writeReportFile(serverCheckRepository.getServerName(), ".txt", result, OSDiskUsage.class);
 	}
 
 	@Override

Repository/build.gradle

@@ -16,6 +16,7 @@ dependencies {
     // Apache Commons Library
     implementation 'commons-io:commons-io:2.8.0'
     implementation 'org.apache.commons:commons-configuration2:2.7'
+    implementation 'org.apache.commons:commons-lang3:3.11'
 
     // Apache POI
     implementation 'org.apache.poi:poi:3.17'

Repository/src/main/java/root/repository/implement/ReportFileRepo.java

@@ -3,7 +3,6 @@
 import java.io.BufferedReader;
 import java.io.BufferedWriter;
 import java.io.File;
-import java.io.FileNotFoundException;
 import java.io.FileReader;
 import java.io.FileWriter;
 import java.io.IOException;
@@ -48,10 +47,13 @@ public static ReportRepository getInstance() {
 	 * 모니터링 결과를 파일에 기록한다.
 	 */
 	@Override
-	public <T> void writeReportFile(String filePath, String fileName, String fileExtension, List<T> monitoringResult,
-			Class<T> clazz) {
-
-		File file = new File(rootDirectory + "/" + filePath + "/" + fileName + fileExtension);
+	public <T> void writeReportFile(String fileName, String fileExtension, List<T> monitoringResult, Class<T> clazz) {
+		if (monitoringResult == null || monitoringResult.size() == 0) {
+			log.info("there is no monitoring result to write report");
+			return;
+		}
+		
+		File file = new File(monitoringFileDirMap.get(clazz) + "/" + fileName + fileExtension);
 		String content = null;
 		try {
 
@@ -70,7 +72,7 @@ public <T> void writeReportFile(String filePath, String fileName, String fileExt
 				content = StringUtils.joinWith(System.lineSeparator(), content, row);
 			}
 		} catch (Exception e) {
-			e.printStackTrace();
+			log.error(e.getMessage());
 		}
 
 		if (content == null) {
@@ -83,7 +85,7 @@ public <T> void writeReportFile(String filePath, String fileName, String fileExt
 			bw.flush();
 			bw.close();
 		} catch (IOException e) {
-			e.printStackTrace();
+			log.error(e.getMessage());
 		}
 	}
 
@@ -103,11 +105,9 @@ public List<String> getReportHeaders(Class<?> monitoringType, String alias) {
 				result.add(headerMap.get(i));
 			}
 
-		} catch (FileNotFoundException e) {
-			e.printStackTrace();
 		} catch (IOException e) {
-			e.printStackTrace();
-		}
+			log.error(e.getMessage());
+		} 
 
 		return result;
 	}
@@ -125,10 +125,8 @@ public String getReportContentsInCsv(Class<?> monitoringType, String alias) {
 				result.append(line).append(System.lineSeparator());
 			}
 
-		} catch (FileNotFoundException e) {
-			e.printStackTrace();
 		} catch (IOException e) {
-			e.printStackTrace();
+			log.error(e.getMessage());
 		}
 
 		return result.toString();