Skip to content

Commit 3953216

Browse files
committed
IDEV-2020: Fix type hint to FeedsResults. It should be the .response() that is of Generator type.
1 parent 9bb7e8c commit 3953216

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

domaintools/api.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from datetime import datetime, timedelta, timezone
22
from hashlib import sha1, sha256, md5
33
from hmac import new as hmac
4-
from typing import Generator
54

65
import re
76

@@ -1068,7 +1067,7 @@ def iris_detect_ignored_domains(
10681067
**kwargs,
10691068
)
10701069

1071-
def nod(self, **kwargs) -> Generator:
1070+
def nod(self, **kwargs) -> FeedsResults:
10721071
"""Returns back list of the newly observed domains feed"""
10731072
validate_feeds_parameters(kwargs)
10741073
endpoint = kwargs.pop("endpoint", Endpoint.FEED.value)
@@ -1085,7 +1084,7 @@ def nod(self, **kwargs) -> Generator:
10851084
**kwargs,
10861085
)
10871086

1088-
def nad(self, **kwargs) -> Generator:
1087+
def nad(self, **kwargs) -> FeedsResults:
10891088
"""Returns back list of the newly active domains feed"""
10901089
validate_feeds_parameters(kwargs)
10911090
endpoint = kwargs.pop("endpoint", Endpoint.FEED.value)
@@ -1102,7 +1101,7 @@ def nad(self, **kwargs) -> Generator:
11021101
**kwargs,
11031102
)
11041103

1105-
def domainrdap(self, **kwargs) -> Generator:
1104+
def domainrdap(self, **kwargs) -> FeedsResults:
11061105
"""Returns changes to global domain registration information, populated by the Registration Data Access Protocol (RDAP)"""
11071106
validate_feeds_parameters(kwargs)
11081107
endpoint = kwargs.pop("endpoint", Endpoint.FEED.value)
@@ -1116,7 +1115,7 @@ def domainrdap(self, **kwargs) -> Generator:
11161115
**kwargs,
11171116
)
11181117

1119-
def domaindiscovery(self, **kwargs) -> Generator:
1118+
def domaindiscovery(self, **kwargs) -> FeedsResults:
11201119
"""Returns new domains as they are either discovered in domain registration information, observed by our global sensor network, or reported by trusted third parties"""
11211120
validate_feeds_parameters(kwargs)
11221121
endpoint = kwargs.pop("endpoint", Endpoint.FEED.value)

0 commit comments

Comments
 (0)