fix #1107 DataTable-GroupingPlugin: Entire group row should be clickable

Author: vegegoku

domino-ui/src/main/java/org/dominokit/domino/ui/datatable/plugins/grouping/GroupingPlugin.java

@@ -28,6 +28,7 @@
 import org.dominokit.domino.ui.datatable.TableRow;
 import org.dominokit.domino.ui.datatable.events.OnBeforeDataChangeEvent;
 import org.dominokit.domino.ui.datatable.plugins.DataTablePlugin;
+import org.dominokit.domino.ui.datatable.plugins.HasPluginConfig;
 import org.dominokit.domino.ui.elements.DivElement;
 import org.dominokit.domino.ui.icons.ToggleIcon;
 import org.dominokit.domino.ui.icons.ToggleMdiIcon;
@@ -63,13 +64,17 @@
  *
  * @param <T> The data type of the DataTable.
  */
-public class GroupingPlugin<T> implements DataTablePlugin<T>, TableConfig.RowAppender<T> {
+public class GroupingPlugin<T>
+    implements DataTablePlugin<T>,
+        TableConfig.RowAppender<T>,
+        HasPluginConfig<T, GroupingPlugin<T>, GroupingPluginConfig> {
 
   private Map<String, DataGroup<T>> dataGroups = new HashMap<>();
   private final GroupSupplier<T> groupSupplier;
   private GroupCellRenderer<T> groupRenderer;
   private Supplier<ToggleIcon<?, ?>> groupExpandedCollapseIconSupplier =
       () -> ToggleMdiIcon.create(Icons.minus_box(), Icons.plus_box());
+  private GroupingPluginConfig config = new GroupingPluginConfig();
 
   /**
    * Creates a new {@code GroupingPlugin} instance with the given group supplier and group renderer.
@@ -131,15 +136,27 @@ public void appendRow(DataTable<T> dataTable, TableRow<T> tableRow) {
       GroupCell<T> groupCell = new GroupCell<>(cellInfo);
       DataGroup<T> dataGroup = new DataGroup<>(tableRow, groupCell);
 
-      ToggleIcon<?, ?> groupIconSupplier =
+      ToggleIcon<?, ?> groupToggleIcon =
           groupExpandedCollapseIconSupplier
               .get()
               .clickable()
               .toggleOnClick(true)
-              .addClickListener(evt -> dataGroup.toggleGroup());
-      dataGroup.setGroupIconSupplier(groupIconSupplier).setGroupRenderer(groupRenderer).render();
+              .addClickListener(
+                  evt -> {
+                    evt.stopPropagation();
+                    dataGroup.toggleGroup();
+                  });
+      dataGroup.setGroupIconSupplier(groupToggleIcon).setGroupRenderer(groupRenderer).render();
+
+      if (config.isToggleGroupOnClick()) {
+        groupCell.addClickListener(
+            evt -> {
+              dataGroup.toggleGroup();
+              groupToggleIcon.toggle();
+            });
+      }
 
-      groupPrefix.appendChild(groupIconSupplier);
+      groupPrefix.appendChild(groupToggleIcon);
 
       dataTable
           .bodyElement()
@@ -201,6 +218,21 @@ public void handleEvent(DominoEvent event) {
     }
   }
 
+  @Override
+  public GroupingPlugin<T> setConfig(GroupingPluginConfig config) {
+    if (nonNull(config)) {
+      this.config = config;
+    } else {
+      this.config = GroupingPluginConfig.create();
+    }
+    return this;
+  }
+
+  @Override
+  public GroupingPluginConfig getConfig() {
+    return this.config;
+  }
+
   /**
    * The {@code DataGroup} class represents a group of data rows in the DataTable. It is used for
    * grouping and rendering data rows as a single group.

domino-ui/src/main/java/org/dominokit/domino/ui/datatable/plugins/grouping/GroupingPluginConfig.java

@@ -0,0 +1,36 @@
+/*
+ * Copyright © 2019 Dominokit
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.dominokit.domino.ui.datatable.plugins.grouping;
+
+import org.dominokit.domino.ui.datatable.plugins.PluginConfig;
+
+public class GroupingPluginConfig implements PluginConfig {
+
+  private boolean toggleGroupOnClick;
+
+  public static GroupingPluginConfig create() {
+    return new GroupingPluginConfig();
+  }
+
+  public boolean isToggleGroupOnClick() {
+    return toggleGroupOnClick;
+  }
+
+  public GroupingPluginConfig setToggleGroupOnClick(boolean toggleGroupOnClick) {
+    this.toggleGroupOnClick = toggleGroupOnClick;
+    return this;
+  }
+}