feat: Add ReactiveRenderSystem, ReactiveSyncSystem, and ReactiveUpdateSystem classes with event system integration

Author: DonColon

src/core/ecs/ReactiveRenderSystem.ts

@@ -0,0 +1,10 @@
+import { EventSystem } from "@/core/events/EventSystem";
+import { GameCoreService } from "@/core/service/GameCoreService";
+import { RenderSystem } from "@/core/ecs/RenderSystem";
+
+export abstract class ReactiveRenderSystem extends RenderSystem {
+	@GameCoreService(EventSystem)
+	protected eventSystem!: EventSystem;
+
+	public execute(elapsed: number, frame: number): void {}
+}

src/core/ecs/ReactiveSyncSystem.ts

@@ -0,0 +1,10 @@
+import { EventSystem } from "@/core/events/EventSystem";
+import { GameCoreService } from "@/core/service/GameCoreService";
+import { SyncSystem } from "@/core/ecs/SyncSystem";
+
+export abstract class ReactiveSyncSystem extends SyncSystem {
+	@GameCoreService(EventSystem)
+	protected eventSystem!: EventSystem;
+
+	public execute(elapsed: number, frame: number): void {}
+}

src/core/ecs/ReactiveSystem.ts src/core/ecs/ReactiveUpdateSystem.tssrc/core/ecs/ReactiveSystem.ts renamed to src/core/ecs/ReactiveUpdateSystem.ts

@@ -2,9 +2,9 @@ import { EventSystem } from "@/core/events/EventSystem";
 import { GameCoreService } from "@/core/service/GameCoreService";
 import { UpdateSystem } from "@/core/ecs/UpdateSystem";
 
-export abstract class ReactiveSystem extends UpdateSystem {
+export abstract class ReactiveUpdateSystem extends UpdateSystem {
     @GameCoreService(EventSystem)
     protected eventSystem!: EventSystem;
 
     public execute(elapsed: number, frame: number): void {}
-}
+}

src/core/ecs/SyncSystem.ts

@@ -0,0 +1,3 @@
+import { System } from "./System";
+
+export abstract class SyncSystem extends System {}

src/core/ecs/World.ts

@@ -11,6 +11,7 @@ import { GameStateConstructor } from "@/core/GameState";
 import { GameCoreService } from "@/core/service/GameCoreService";
 import { EventSystem } from "@/core/events/EventSystem";
 import { binaryInsert } from "@/core/utils/Arrays";
+import { SyncSystem } from "./SyncSystem";
 
 @GameCoreService()
 export class World {
@@ -20,6 +21,7 @@ export class World {
 	private readonly systems: Map<string, System>;
 
 	private updateSchedule: System[];
+	private syncSchedule: System[];
 	private renderSchedule: System[];
 
 	@GameCoreService(EventSystem)
@@ -32,6 +34,7 @@ export class World {
 		this.systems = new Map<string, System>();
 
 		this.updateSchedule = [];
+		this.syncSchedule = [];
 		this.renderSchedule = [];
 	}
 
@@ -41,6 +44,12 @@ export class World {
 				system.execute(elapsed, frame);
 			}
 		}
+
+		for (const system of this.syncSchedule) {
+			if (system.isEnabled()) {
+				system.execute(elapsed, frame);
+			}
+		}
 	}
 
 	public render(elapsed: number, frame: number) {
@@ -186,6 +195,8 @@ export class World {
 	private scheduleSystem(system: System) {
 		if (system instanceof UpdateSystem) {
 			binaryInsert(this.updateSchedule, system, System.byPriority);
+		} else if (system instanceof SyncSystem) {
+			binaryInsert(this.syncSchedule, system, System.byPriority);
 		} else if (system instanceof RenderSystem) {
 			binaryInsert(this.renderSchedule, system, System.byPriority);
 		} else {
@@ -205,6 +216,8 @@ export class World {
 	private unscheduleSystem(system: System) {
 		if (system instanceof UpdateSystem) {
 			this.updateSchedule = this.updateSchedule.filter(s => s !== system);
+		} else if (system instanceof SyncSystem) {
+			this.syncSchedule = this.syncSchedule.filter(s => s !== system);
 		} else if (system instanceof RenderSystem) {
 			this.renderSchedule = this.renderSchedule.filter(s => s !== system);
 		} else {
@@ -226,6 +239,10 @@ export class World {
 		return this.updateSchedule;
 	}
 
+	public getSyncSchedule(): System[] {
+		return this.syncSchedule;
+	}
+
 	public getRenderSchedule(): System[] {
 		return this.renderSchedule;
 	}

test/core/ecs/ReactiveSystem.spec.ts

@@ -1,5 +1,5 @@
 import { test, expect, suite, vi } from "vitest";
-import { ReactiveSystem } from "@/core/ecs/ReactiveSystem";
+import { ReactiveUpdateSystem } from "@/core/ecs/ReactiveUpdateSystem";
 import { Query } from "@/core/ecs/Query";
 import { ServiceRegistry } from "@/core/service/ServiceRegistry";
 import { EventSystem } from "@/core/events/EventSystem";
@@ -9,14 +9,14 @@ import { Entity } from "@/core/ecs/Entity";
 suite("ReactiveSystem Test Suite", () => {
 	let entityChanged = false;
 
-	class TestReactiveSystem extends ReactiveSystem {
+	class TestReactiveSystem extends ReactiveUpdateSystem {
 		queries = {
 			query: new Query({
 				allowlist: [],
 				blocklist: []
 			})
 		};
-		
+
 		public initialize(): void {
 			this.eventSystem.subscribeOnce("entityChanged", () => {
 				entityChanged = true;
@@ -43,10 +43,10 @@ suite("ReactiveSystem Test Suite", () => {
 
 	test("ReactiveSystem execute method does nothing by default", () => {
 		const system = new TestReactiveSystem(0);
-		
+
 		// Execute should not throw and does nothing
 		expect(() => system.execute(16, 1)).not.toThrow();
-		
+
 		// Verify it was called (even though it does nothing)
 		const executeSpy = vi.spyOn(system, 'execute');
 		system.execute(16, 1);
@@ -57,17 +57,17 @@ suite("ReactiveSystem Test Suite", () => {
 		const system = new TestReactiveSystem(5);
 
 		expect(system.isEnabled()).toBeTruthy();
-		
+
 		system.disable();
 		expect(system.isEnabled()).toBeFalsy();
-		
+
 		system.enable();
 		expect(system.isEnabled()).toBeTruthy();
 	});
 
 	test("ReactiveSystem can access queries", () => {
 		const system = new TestReactiveSystem(0);
-		
+
 		expect(system.queries).toBeDefined();
 		expect(system.queries.query).toBeInstanceOf(Query);
 	});