Remove insider prompt (#18810)

* Remove pre-release prompt
* Add news item

Author: karthiknadig

news/3 Code Health/18809.md

@@ -0,0 +1 @@
+Remove prompt to recommend users in old insiders program to switch to pre-release.

package.nls.json

@@ -216,8 +216,5 @@
     "TensorBoard.launchNativeTensorBoardSessionCodeLens": "▶ Launch TensorBoard Session",
     "TensorBoard.enterRemoteUrl": "Enter remote URL",
     "TensorBoard.enterRemoteUrlDetail": "Enter a URL pointing to a remote directory containing your TensorBoard log files",
-    "SwitchToDefaultLS.bannerMessage": "The Microsoft Python Language Server has reached end of life. Your language server has been set to the default for Python in VS Code, Pylance. If you’d like to change your language server, you can learn about how to do so [here](https://devblogs.microsoft.com/python/python-in-visual-studio-code-may-2021-release/#configuring-your-language-server). Read Pylance’s license [here](https://marketplace.visualstudio.com/items/ms-python.vscode-pylance/license).",
-    "SwitchToPrereleaseExtension.bannerMessage": "We now have a new way to get pre-release (insiders) version of the Python extension. See [here](https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions) to learn more.",
-    "SwitchToPrereleaseExtension.installPreRelease": "Install Pre-Release",
-    "SwitchToPrereleaseExtension.installStable": "Install Stable"
+    "SwitchToDefaultLS.bannerMessage": "The Microsoft Python Language Server has reached end of life. Your language server has been set to the default for Python in VS Code, Pylance. If you’d like to change your language server, you can learn about how to do so [here](https://devblogs.microsoft.com/python/python-in-visual-studio-code-may-2021-release/#configuring-your-language-server). Read Pylance’s license [here](https://marketplace.visualstudio.com/items/ms-python.vscode-pylance/license)."
 }

src/client/application/diagnostics/checks/switchToPreReleaseExtension.ts

@@ -40,10 +40,6 @@ import {
     SwitchToDefaultLanguageServerDiagnosticService,
     SwitchToDefaultLanguageServerDiagnosticServiceId,
 } from './checks/switchToDefaultLS';
-import {
-    SwitchToPreReleaseExtensionDiagnosticService,
-    SwitchToPreReleaseExtensionDiagnosticServiceId,
-} from './checks/switchToPreReleaseExtension';
 import { DiagnosticsCommandFactory } from './commands/factory';
 import { IDiagnosticsCommandFactory } from './commands/types';
 import { DiagnosticFilterService } from './filter';
@@ -115,12 +111,6 @@ export function registerTypes(serviceManager: IServiceManager): void {
         SwitchToDefaultLanguageServerDiagnosticServiceId,
     );
 
-    serviceManager.addSingleton<IDiagnosticsService>(
-        IDiagnosticsService,
-        SwitchToPreReleaseExtensionDiagnosticService,
-        SwitchToPreReleaseExtensionDiagnosticServiceId,
-    );
-
     serviceManager.addSingleton<IDiagnosticsCommandFactory>(IDiagnosticsCommandFactory, DiagnosticsCommandFactory);
     serviceManager.addSingleton<IApplicationDiagnostics>(IApplicationDiagnostics, ApplicationDiagnostics);
 }

src/client/application/diagnostics/serviceRegistry.ts

@@ -535,15 +535,6 @@ export namespace SwitchToDefaultLS {
     );
 }
 
-export namespace SwitchToPrereleaseExtension {
-    export const bannerMessage = localize(
-        'SwitchToPrereleaseExtension.bannerMessage',
-        'We now have a new way to get pre-release/insiders version of the Python extension. See [here](https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions) to learn more.',
-    );
-    export const installPreRelease = localize('SwitchToPrereleaseExtension.installPreRelease', 'Install Pre-Release');
-    export const installStable = localize('SwitchToPrereleaseExtension.installStable', 'Install Stable');
-}
-
 function localize(key: string, defValue?: string) {
     // Return a pointer to function so that we refetch it on each call.
     return (): string => getString(key, defValue);

src/client/common/utils/localize.ts

@@ -41,10 +41,6 @@ import {
     SwitchToDefaultLanguageServerDiagnosticService,
     SwitchToDefaultLanguageServerDiagnosticServiceId,
 } from '../../../client/application/diagnostics/checks/switchToDefaultLS';
-import {
-    SwitchToPreReleaseExtensionDiagnosticService,
-    SwitchToPreReleaseExtensionDiagnosticServiceId,
-} from '../../../client/application/diagnostics/checks/switchToPreReleaseExtension';
 import { DiagnosticsCommandFactory } from '../../../client/application/diagnostics/commands/factory';
 import { IDiagnosticsCommandFactory } from '../../../client/application/diagnostics/commands/types';
 import { DiagnosticFilterService } from '../../../client/application/diagnostics/filter';
@@ -144,14 +140,6 @@ suite('Application Diagnostics - Register classes in IOC Container', () => {
                 SwitchToDefaultLanguageServerDiagnosticServiceId,
             ),
         );
-        verify(
-            serviceManager.addSingleton<IDiagnosticsService>(
-                IDiagnosticsService,
-                SwitchToPreReleaseExtensionDiagnosticService,
-                SwitchToPreReleaseExtensionDiagnosticServiceId,
-            ),
-        );
-
         verify(
             serviceManager.addSingleton<IDiagnosticsCommandFactory>(
                 IDiagnosticsCommandFactory,