Skip to content

Commit 3fa8d98

Browse files
mouhc1neDonalEvans
authored andcommitted
ESQL: URL encoding changes (elastic#134503)
- Change URL_ENCODE to encode spaces as +. - Add a new URL_ENCODE_COMPONENT scalar function, which encodes spaces as %20. - Both encoding functions encode all characters in the input except for alphanumerics, ., -, _, and ~. - Allow URL_DECODE to fail gracefully if the input can't be decoded, by returning null and adding a warning in the header, similar to other scalar functions. - Manually perform percent-encoding directly on the BreakingBytesRefBuilder scratch area, and only if the input was gonna change after encoding. - Update csv-tests: - Test decoding for both + and %20 back to space. - Reduce the length of doc lines to less than 76 chars, as mentioned in the contribution guide. - Add test cases with fixed strings - Minor changes to the documentation. - Update Unit tests: - Add fixed test cases that fail decoding - Randomize the encoder used in decoding tests - Use Apache's PercentEncode as the ground truth during unit testing.
1 parent 41f89ee commit 3fa8d98

File tree

35 files changed

+933
-102
lines changed

35 files changed

+933
-102
lines changed

docs/reference/query-languages/esql/_snippets/functions/description/url_decode.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/description/url_encode.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/description/url_encode_component.md

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/examples/url_decode.md

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/examples/url_encode.md

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/examples/url_encode_component.md

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/layout/url_encode_component.md

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/parameters/url_decode.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/parameters/url_encode.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/parameters/url_encode_component.md

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)