fix: pool size configuration (operator-framework#2810)

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java

@@ -254,13 +254,20 @@ public boolean closeClientOnStop() {
 
       @Override
       public ExecutorService getExecutorService() {
-        return overriddenValueOrDefault(executorService, ConfigurationService::getExecutorService);
+        if (executorService != null) {
+          return executorService;
+        } else {
+          return super.getExecutorService();
+        }
       }
 
       @Override
       public ExecutorService getWorkflowExecutorService() {
-        return overriddenValueOrDefault(
-            workflowExecutorService, ConfigurationService::getWorkflowExecutorService);
+        if (workflowExecutorService != null) {
+          return workflowExecutorService;
+        } else {
+          return super.getWorkflowExecutorService();
+        }
       }
 
       @Override

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverriderTest.java

@@ -3,12 +3,14 @@
 import java.time.Duration;
 import java.util.Optional;
 import java.util.concurrent.Executors;
+import java.util.concurrent.ThreadPoolExecutor;
 
 import org.junit.jupiter.api.Test;
 
 import io.fabric8.kubernetes.api.model.HasMetadata;
 import io.javaoperatorsdk.operator.api.monitoring.Metrics;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
 class ConfigurationServiceOverriderTest {
@@ -26,30 +28,32 @@ public <R extends HasMetadata> R clone(R object) {
         }
       };
 
+  final BaseConfigurationService config =
+      new BaseConfigurationService(null) {
+        @Override
+        public boolean checkCRDAndValidateLocalModel() {
+          return false;
+        }
+
+        @Override
+        public Metrics getMetrics() {
+          return METRICS;
+        }
+
+        @Override
+        public Cloner getResourceCloner() {
+          return CLONER;
+        }
+
+        @Override
+        public Optional<LeaderElectionConfiguration> getLeaderElectionConfiguration() {
+          return Optional.of(LEADER_ELECTION_CONFIGURATION);
+        }
+      };
+
   @Test
   void overrideShouldWork() {
-    final var config =
-        new BaseConfigurationService(null) {
-          @Override
-          public boolean checkCRDAndValidateLocalModel() {
-            return false;
-          }
-
-          @Override
-          public Metrics getMetrics() {
-            return METRICS;
-          }
-
-          @Override
-          public Cloner getResourceCloner() {
-            return CLONER;
-          }
-
-          @Override
-          public Optional<LeaderElectionConfiguration> getLeaderElectionConfiguration() {
-            return Optional.of(LEADER_ELECTION_CONFIGURATION);
-          }
-        };
+
     final var overridden =
         new ConfigurationServiceOverrider(config)
             .checkingCRDAndValidateLocalModel(true)
@@ -86,4 +90,17 @@ public <R extends HasMetadata> R clone(R object) {
     assertNotEquals(
         config.reconciliationTerminationTimeout(), overridden.reconciliationTerminationTimeout());
   }
+
+  @Test
+  void threadCountConfiguredProperly() {
+    final var overridden =
+        new ConfigurationServiceOverrider(config)
+            .withConcurrentReconciliationThreads(13)
+            .withConcurrentWorkflowExecutorThreads(14)
+            .build();
+    assertThat(((ThreadPoolExecutor) overridden.getExecutorService()).getMaximumPoolSize())
+        .isEqualTo(13);
+    assertThat(((ThreadPoolExecutor) overridden.getWorkflowExecutorService()).getMaximumPoolSize())
+        .isEqualTo(14);
+  }
 }