Skip to content

Commit 1952c0a

Browse files
committed
Improve project structure
1 parent f6f81ff commit 1952c0a

File tree

7 files changed

+29
-26
lines changed

7 files changed

+29
-26
lines changed

src/main/java/de/donnerbart/split/TestSplit.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
import com.github.javaparser.JavaParser;
55
import com.github.javaparser.ast.body.ClassOrInterfaceDeclaration;
66
import com.github.javaparser.ast.expr.AnnotationExpr;
7+
import de.donnerbart.split.model.Split;
8+
import de.donnerbart.split.model.TestCase;
9+
import de.donnerbart.split.model.TestSuite;
710
import org.jetbrains.annotations.NotNull;
811
import org.jetbrains.annotations.Nullable;
912
import org.slf4j.Logger;
@@ -23,8 +26,7 @@
2326
import java.util.function.Consumer;
2427
import java.util.stream.Collectors;
2528

26-
import static de.donnerbart.split.Util.formatIndex;
27-
import static de.donnerbart.split.Util.formatTime;
29+
import static de.donnerbart.split.util.FormatUtil.formatTime;
2830

2931
public class TestSplit {
3032

@@ -130,12 +132,12 @@ public void run() throws Exception {
130132
if (debug) {
131133
final var fastestSplit = splits.stream().min(Comparator.naturalOrder()).orElseThrow();
132134
LOG.debug("Fastest test plan is #{} with {} tests ({})",
133-
formatIndex(fastestSplit.index()),
135+
fastestSplit.formatIndex(),
134136
fastestSplit.tests().size(),
135137
formatTime(fastestSplit.totalRecordedTime()));
136138
final var slowestSplit = splits.stream().max(Comparator.naturalOrder()).orElseThrow();
137139
LOG.debug("Slowest test plan is #{} with {} tests ({})",
138-
formatIndex(slowestSplit.index()),
140+
slowestSplit.formatIndex(),
139141
slowestSplit.tests().size(),
140142
formatTime(slowestSplit.totalRecordedTime()));
141143
LOG.debug("Difference between the fastest and slowest test plan: {}",

src/main/java/de/donnerbart/split/Split.java renamed to src/main/java/de/donnerbart/split/model/Split.java

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
package de.donnerbart.split;
1+
package de.donnerbart.split.model;
22

3+
import de.donnerbart.split.util.FormatUtil;
34
import org.jetbrains.annotations.NotNull;
45
import org.jetbrains.annotations.Nullable;
56

@@ -8,26 +9,30 @@
89
import java.util.Set;
910
import java.util.stream.Collectors;
1011

11-
class Split implements Comparable<Split> {
12+
public class Split implements Comparable<Split> {
1213

1314
private final @NotNull Set<TestCase> tests = new HashSet<>();
1415
private final int index;
1516

1617
private double totalRecordedTime;
1718

18-
Split(final int index) {
19+
public Split(final int index) {
1920
this.index = index;
2021
}
2122

22-
int index() {
23+
public int index() {
2324
return index;
2425
}
2526

26-
double totalRecordedTime() {
27+
public @NotNull String formatIndex() {
28+
return String.format("%02d", index);
29+
}
30+
31+
public double totalRecordedTime() {
2732
return totalRecordedTime;
2833
}
2934

30-
@NotNull Set<TestCase> tests() {
35+
public @NotNull Set<TestCase> tests() {
3136
return tests;
3237
}
3338

@@ -61,17 +66,17 @@ public int hashCode() {
6166
public String toString() {
6267
return "Split{" +
6368
"index=" +
64-
Util.formatIndex(index) +
69+
formatIndex() +
6570
", totalRecordedTime=" +
66-
Util.formatTime(totalRecordedTime) +
71+
FormatUtil.formatTime(totalRecordedTime) +
6772
", testCount=" +
6873
tests.size() +
6974
", tests=" +
7075
tests.stream().map(TestCase::name).collect(Collectors.joining(", ")) +
7176
'}';
7277
}
7378

74-
void add(final @NotNull TestCase testCase) {
79+
public void add(final @NotNull TestCase testCase) {
7580
tests.add(testCase);
7681
totalRecordedTime += testCase.time();
7782
}

src/main/java/de/donnerbart/split/TestCase.java renamed to src/main/java/de/donnerbart/split/model/TestCase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
package de.donnerbart.split;
1+
package de.donnerbart.split.model;
22

33
import org.jetbrains.annotations.NotNull;
44
import org.jetbrains.annotations.Nullable;
55

66
import java.util.Objects;
77

8-
record TestCase(@NotNull String name, double time) implements Comparable<TestCase> {
8+
public record TestCase(@NotNull String name, double time) implements Comparable<TestCase> {
99

1010
@Override
1111
public int compareTo(final @NotNull TestCase o) {

src/main/java/de/donnerbart/split/TestSuite.java renamed to src/main/java/de/donnerbart/split/model/TestSuite.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package de.donnerbart.split;
1+
package de.donnerbart.split.model;
22

33
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
44
import com.fasterxml.jackson.annotation.JsonProperty;

src/main/java/de/donnerbart/split/Util.java renamed to src/main/java/de/donnerbart/split/util/FormatUtil.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
1-
package de.donnerbart.split;
1+
package de.donnerbart.split.util;
22

33
import org.jetbrains.annotations.NotNull;
44

5-
public class Util {
5+
public class FormatUtil {
66

7-
private Util() {
7+
private FormatUtil() {
88
}
99

10-
static @NotNull String formatIndex(final int index) {
11-
return String.format("%02d", index);
12-
}
13-
14-
static @NotNull String formatTime(final double time) {
10+
public static @NotNull String formatTime(final double time) {
1511
final var minutes = (int) Math.floor(time / 60d);
1612
final var seconds = Math.round(time - (minutes * 60));
1713
return String.format("%02dm%02ds", minutes, seconds);

src/test/java/de/donnerbart/split/SplitTest.java renamed to src/test/java/de/donnerbart/split/model/SplitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package de.donnerbart.split;
1+
package de.donnerbart.split.model;
22

33
import nl.jqno.equalsverifier.EqualsVerifier;
44
import org.junit.jupiter.api.Test;

src/test/java/de/donnerbart/split/TestCaseTest.java renamed to src/test/java/de/donnerbart/split/model/TestCaseTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package de.donnerbart.split;
1+
package de.donnerbart.split.model;
22

33
import nl.jqno.equalsverifier.EqualsVerifier;
44
import org.junit.jupiter.api.Test;

0 commit comments

Comments
 (0)