Improve handling of unreadable test files

Author: Donnerbart

src/main/java/de/donnerbart/split/TestLoader.java

@@ -117,23 +117,24 @@ public TestLoader(
         Files.walkFileTree(rootPath, new SimpleFileVisitor<>() {
             @Override
             public @NotNull FileVisitResult visitFile(
-                    final @Nullable Path path,
+                    final @NotNull Path path,
                     final @NotNull BasicFileAttributes attributes) {
-                if (path != null) {
-                    final var candidate = path.normalize();
-                    if (includeMatcher.matches(candidate)) {
-                        if (excludeMatcher.matches(candidate)) {
-                            LOG.debug("Excluding test file {}", candidate);
-                        } else {
-                            files.add(candidate);
-                        }
+                final var candidate = path.normalize();
+                if (includeMatcher.matches(candidate)) {
+                    if (excludeMatcher.matches(candidate)) {
+                        LOG.debug("Excluding test file {}", candidate);
+                    } else if (!Files.isReadable(candidate)) {
+                        LOG.debug("Ignoring unreadable file {}", candidate);
+                    } else {
+                        files.add(candidate);
                     }
                 }
                 return FileVisitResult.CONTINUE;
             }
 
             @Override
-            public @NotNull FileVisitResult visitFileFailed(final @Nullable Path file, final @NotNull IOException e) {
+            public @NotNull FileVisitResult visitFileFailed(final @NotNull Path path, final @NotNull IOException e) {
+                LOG.debug("Ignoring unreadable path {}", path.normalize());
                 return FileVisitResult.CONTINUE;
             }
         });

src/test/java/de/donnerbart/split/TestLoaderTest.java

@@ -38,7 +38,15 @@ void setUp() throws Exception {
                 .resolve("de")
                 .resolve("donnerbart")
                 .resolve("example");
-        Files.createDirectories(projectFolder);
+        final var unreadableFolder = projectFolder.resolve("unreadable");
+        Files.createDirectories(unreadableFolder);
+        // unreadable tests
+        copyResourceToTarget(projectFolder, "tests/UnreadableTest.java", "UnreadableTest.java", Set.of());
+        copyResourceToTarget(unreadableFolder,
+                "tests/UnreadableNestedTest.java",
+                "UnreadableNestedTest.java",
+                PERMISSIONS);
+        Files.setPosixFilePermissions(unreadableFolder, Set.of());
         // ignored tests
         copyResourceToTarget(projectFolder, "tests/AbstractTest.java", "AbstractTest.java", PERMISSIONS);
         copyResourceToTarget(projectFolder, "tests/BaseTest.java", "BaseTest.java", PERMISSIONS);

src/test/java/de/donnerbart/split/TestUtil.java

@@ -32,9 +32,7 @@ private TestUtil() {
             }
 
             Files.copy(Path.of(resource.toURI()), path);
-            if (!permissions.isEmpty()) {
-                Files.setPosixFilePermissions(path, permissions);
-            }
+            Files.setPosixFilePermissions(path, permissions);
             return path.toAbsolutePath();
         } catch (final Exception e) {
             throw new AssertionError("Could not copy resource file to target", e);

src/test/resources/tests/UnreadableNestedTest.java

@@ -0,0 +1,10 @@
+package de.donnerbart.example.unreadable;
+
+import org.junit.jupiter.api.Test;
+
+class UnreadableNestedTest {
+
+    @Test
+    void testUnreadableMethod() {
+    }
+}

src/test/resources/tests/UnreadableTest.java

@@ -0,0 +1,10 @@
+package de.donnerbart.example;
+
+import org.junit.jupiter.api.Test;
+
+class UnreadableTest {
+
+    @Test
+    void testUnreadableMethod() {
+    }
+}