Skip to content

Commit 17ab838

Browse files
authored
fix: use correct project name for otel default service name (#406)
1 parent 192a9a8 commit 17ab838

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

README.md

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,23 @@ spec:
8181
webhookPath: /hooks/ixuxbmoofkiq9s2l61h6i2sl6hdgwnud
8282
```
8383

84+
## Request flow
85+
```mermaid
86+
flowchart LR
87+
ReceiverA["Receiver A"]
88+
WebhookControllerIngress["Webhook Controller Ingress"]
89+
ServiceA["Service A"]
90+
ServiceB["Service B"]
91+
ServiceC["Service C"]
92+
WebhookController["WebhookController"]
93+
94+
WebhookControllerIngress-- HTTP Request https://ingres-host/hooks/ixuxbmoofkiq9s2l61h6i2sl6hdgwnud -->WebhookController
95+
WebhookController-- Look for receiver matching /hooks/ixuxbmoofkiq9s2l61h6i2sl6hdgwnud -->ReceiverA
96+
ReceiverA-- Clone request and forward -->ServiceA
97+
ReceiverA-- Clone request and forward -->ServiceB
98+
ReceiverA-- Clone request and forward -->ServiceC
99+
```
100+
84101
## More configurations
85102

86103
### Response type
@@ -215,7 +232,7 @@ The controller can be configured using cmd args:
215232
--min-retry-delay duration The minimum amount of time for which an object being reconciled will have to wait before a retry. (default 750ms)
216233
--otel-endpoint string Opentelemetry gRPC endpoint (without protocol)
217234
--otel-insecure Opentelemetry gRPC disable tls
218-
--otel-service-name string Opentelemetry service name (default "k8skeycloak-controller")
235+
--otel-service-name string Opentelemetry service name (default "webhook-controller")
219236
--otel-tls-client-cert-path string Opentelemetry gRPC mTLS client cert path
220237
--otel-tls-client-key-path string Opentelemetry gRPC mTLS client key path
221238
--otel-tls-root-ca-path string Opentelemetry gRPC mTLS root CA path

internal/otelsetup/options.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func (o *Options) getTLSConfig() (*tls.Config, error) {
4747

4848
// BindFlags will parse the given pflag.FlagSet
4949
func (o *Options) BindFlags(fs *pflag.FlagSet) {
50-
fs.StringVar(&o.ServiceName, "otel-service-name", "k8skeycloak-controller", "Opentelemetry service name")
50+
fs.StringVar(&o.ServiceName, "otel-service-name", "webhook-controller", "Opentelemetry service name")
5151
fs.StringVar(&o.Endpoint, "otel-endpoint", "", "Opentelemetry gRPC endpoint (without protocol)")
5252
fs.BoolVar(&o.Insecure, "otel-insecure", false, "Opentelemetry gRPC disable tls")
5353
fs.StringVar(&o.TLSClientKeyPath, "otel-tls-client-key-path", "", "Opentelemetry gRPC mTLS client key path")

0 commit comments

Comments
 (0)