fix: cleanup (#401)

Author: raffis

README.md

@@ -108,8 +108,8 @@ spec:
 
 The following types are supported:
 * `Async` - The default, does not await reponses from upstream and immeadiately acknowledges incoming requests with a `HTTP 202 Accepted`.
-* `AwaitAllPreferSuccessful` - Await all upstream responses and send back the first successful repsonse (>= 200 && < 400). If all of them are not successful it will send back the first error response.
-* `AwaitAllPreferFailed` - Await all upstream responses and send back the first failed repsonse (< 200 && >= 400). If all of them are successful it will send back the first sucessful response.
+* `AwaitAllPreferSuccessful` - Await all upstream responses and send back the first successful repsonse (>= 200 && < 400). If all of them are not successful it will send back the last failed response.
+* `AwaitAllPreferFailed` - Await all upstream responses and send back the first failed repsonse (< 200 && >= 400). If all of them are successful it will send back the last sucessful response.
 * `AwaitAllReport` - Await all upstream responses and send back a json object containing all target responses including status code, body and headers. The status code of this type will always be `HTTP 200 OK`.
 
 ### Path rewrite

api/v1beta1/receiver_types.go

@@ -104,9 +104,7 @@ type ResourceReference struct {
 }
 
 const (
-	ReadyCondition            = "Ready"
-	ServicePortNotFoundReason = "ServicePortNotFound"
-	ServiceNotFoundReason     = "ServiceNotFound"
+	ConditionReady            = "Ready"
 	ServiceBackendReadyReason = "ServiceBackendReady"
 )
 
@@ -132,13 +130,13 @@ func setResourceCondition(resource conditionalResource, condition string, status
 
 // ReceiverNotReady
 func ReceiverNotReady(clone Receiver, reason, message string) Receiver {
-	setResourceCondition(&clone, ReadyCondition, metav1.ConditionFalse, reason, message)
+	setResourceCondition(&clone, ConditionReady, metav1.ConditionFalse, reason, message)
 	return clone
 }
 
 // ReceiverReady
 func ReceiverReady(clone Receiver, reason, message string) Receiver {
-	setResourceCondition(&clone, ReadyCondition, metav1.ConditionTrue, reason, message)
+	setResourceCondition(&clone, ConditionReady, metav1.ConditionTrue, reason, message)
 	return clone
 }
 

config/base/rbac/cluster_admin_rolebinding.yaml

@@ -5,4 +5,3 @@ resources:
 - role_binding.yaml
 - leader_election_role.yaml
 - leader_election_role_binding.yaml
-- cluster_admin_rolebinding.yaml

config/base/rbac/kustomization.yaml

@@ -86,7 +86,7 @@ var _ = Describe("Receiver controller", func() {
 				ObservedGeneration: 1,
 				Conditions: []metav1.Condition{
 					{
-						Type:    v1beta1.ReadyCondition,
+						Type:    v1beta1.ConditionReady,
 						Status:  metav1.ConditionFalse,
 						Reason:  "ServiceBackendReady",
 						Message: "no targets found",
@@ -142,7 +142,7 @@ var _ = Describe("Receiver controller", func() {
 				ObservedGeneration: 1,
 				Conditions: []metav1.Condition{
 					{
-						Type:    v1beta1.ReadyCondition,
+						Type:    v1beta1.ConditionReady,
 						Status:  metav1.ConditionFalse,
 						Reason:  "ServiceBackendReady",
 						Message: "no targets found",
@@ -181,7 +181,7 @@ var _ = Describe("Receiver controller", func() {
 				ObservedGeneration: 1,
 				Conditions: []metav1.Condition{
 					{
-						Type:    v1beta1.ReadyCondition,
+						Type:    v1beta1.ConditionReady,
 						Status:  metav1.ConditionTrue,
 						Reason:  "ServiceBackendReady",
 						Message: "receiver successfully registered",