Skip to content

Commit ea905f2

Browse files
authored
fix: remove ownerref (#49)
* fix: remove ownerref * fix: ownerrefs
1 parent 5d45058 commit ea905f2

File tree

4 files changed

+26
-24
lines changed

4 files changed

+26
-24
lines changed

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
uses: goreleaser/goreleaser-action@5742e2a039330cbb23ebf35f046f814d4c6ff811 # v5.1.0
3535
with:
3636
version: latest
37-
args: release --rm-dist --skip-validate
37+
args: release --clean --skip=validate
3838
env:
3939
RUNNER_TOKEN: ${{ github.token }}
4040
GITHUB_TOKEN: ${{ secrets.DOODLE_OSS_BOT}}

.gitignore

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Binaries for programs and plugins
2+
*.exe
3+
*.exe~
4+
*.dll
5+
*.so
6+
*.dylib
7+
bin
8+
xunpack
9+
10+
# Test binary, build with `go test -c`
11+
*.test
12+
13+
# Output of the go coverage tool, specifically when used with LiteIDE
14+
*.out
15+
16+
# Kubernetes Generated files - skip generated files, except for vendored files
17+
18+
!vendor/**/zz_generated.*
19+
20+
# editor and IDE paraphernalia
21+
.vscode
22+
.idea
23+
*.swp
24+
*.swo
25+
*~

internal/xcrd/crd.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,9 @@ import (
2626
"encoding/json"
2727

2828
extv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
29-
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3029
"k8s.io/utils/ptr"
3130

3231
"github.com/crossplane/crossplane-runtime/pkg/errors"
33-
"github.com/crossplane/crossplane-runtime/pkg/meta"
3432

3533
v1 "github.com/crossplane/crossplane/apis/apiextensions/v1"
3634
)
@@ -64,10 +62,6 @@ func ForCompositeResource(xrd *v1.CompositeResourceDefinition) (*extv1.CustomRes
6462

6563
crd.SetName(xrd.GetName())
6664
setCrdMetadata(crd, xrd)
67-
crd.SetOwnerReferences([]metav1.OwnerReference{meta.AsController(
68-
meta.TypedReferenceTo(xrd, v1.CompositeResourceDefinitionGroupVersionKind),
69-
)})
70-
7165
crd.Spec.Names.Categories = append(crd.Spec.Names.Categories, CategoryComposite)
7266

7367
for i, vr := range xrd.Spec.Versions {
@@ -104,10 +98,6 @@ func ForCompositeResourceClaim(xrd *v1.CompositeResourceDefinition) (*extv1.Cust
10498

10599
crd.SetName(xrd.Spec.ClaimNames.Plural + "." + xrd.Spec.Group)
106100
setCrdMetadata(crd, xrd)
107-
crd.SetOwnerReferences([]metav1.OwnerReference{meta.AsController(
108-
meta.TypedReferenceTo(xrd, v1.CompositeResourceDefinitionGroupVersionKind),
109-
)})
110-
111101
crd.Spec.Names.Categories = append(crd.Spec.Names.Categories, CategoryClaim)
112102

113103
for i, vr := range xrd.Spec.Versions {

internal/xcrd/crd_test.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import (
3232
"k8s.io/apimachinery/pkg/types"
3333

3434
"github.com/crossplane/crossplane-runtime/pkg/errors"
35-
"github.com/crossplane/crossplane-runtime/pkg/meta"
3635
"github.com/crossplane/crossplane-runtime/pkg/test"
3736

3837
v1 "github.com/crossplane/crossplane/apis/apiextensions/v1"
@@ -163,9 +162,6 @@ func TestForCompositeResource(t *testing.T) {
163162
ObjectMeta: metav1.ObjectMeta{
164163
Name: name,
165164
Labels: labels,
166-
OwnerReferences: []metav1.OwnerReference{
167-
meta.AsController(meta.TypedReferenceTo(d, v1.CompositeResourceDefinitionGroupVersionKind)),
168-
},
169165
},
170166
Spec: extv1.CustomResourceDefinitionSpec{
171167
Group: group,
@@ -477,9 +473,6 @@ func TestForCompositeResourceEmptyXrd(t *testing.T) {
477473
ObjectMeta: metav1.ObjectMeta{
478474
Name: name,
479475
Labels: labels,
480-
OwnerReferences: []metav1.OwnerReference{
481-
meta.AsController(meta.TypedReferenceTo(d, v1.CompositeResourceDefinitionGroupVersionKind)),
482-
},
483476
},
484477
Spec: extv1.CustomResourceDefinitionSpec{
485478
Group: group,
@@ -925,9 +918,6 @@ func TestForCompositeResourceClaim(t *testing.T) {
925918
ObjectMeta: metav1.ObjectMeta{
926919
Name: claimPlural + "." + group,
927920
Labels: labels,
928-
OwnerReferences: []metav1.OwnerReference{
929-
meta.AsController(meta.TypedReferenceTo(d, v1.CompositeResourceDefinitionGroupVersionKind)),
930-
},
931921
},
932922
Spec: extv1.CustomResourceDefinitionSpec{
933923
Group: group,
@@ -1227,9 +1217,6 @@ func TestForCompositeResourceClaimEmptyXrd(t *testing.T) {
12271217
ObjectMeta: metav1.ObjectMeta{
12281218
Name: claimPlural + "." + group,
12291219
Labels: labels,
1230-
OwnerReferences: []metav1.OwnerReference{
1231-
meta.AsController(meta.TypedReferenceTo(d, v1.CompositeResourceDefinitionGroupVersionKind)),
1232-
},
12331220
},
12341221
Spec: extv1.CustomResourceDefinitionSpec{
12351222
Group: group,

0 commit comments

Comments
 (0)