Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

Commit 5a1b01d

Browse files
sharwellsharwell
committed
Update code fixes to use CustomBatchFixAllProvider
1 parent 900f4cf commit 5a1b01d

11 files changed

+1019
-3
lines changed

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers.CodeFixes/AsyncUsageAnalyzers.CodeFixes.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@
4242
<AssemblyOriginatorKeyFile Condition="'$(KeyConfiguration)' != 'Final'">..\..\build\keys\AsyncUsageAnalyzers.dev.snk</AssemblyOriginatorKeyFile>
4343
</PropertyGroup>
4444
<ItemGroup>
45+
<Compile Include="Helpers\CustomBatchFixAllProvider.cs" />
46+
<Compile Include="Helpers\CustomFixAllProviders.cs" />
47+
<Compile Include="Helpers\FixAllContextHelper.cs" />
4548
<Compile Include="Helpers\RenameHelper.cs" />
4649
<Compile Include="Naming\AvoidAsyncSuffixCodeFixProvider.cs" />
4750
<Compile Include="Naming\UseAsyncSuffixCodeFixProvider.cs" />

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers.CodeFixes/Helpers/CustomBatchFixAllProvider.cs

Lines changed: 428 additions & 0 deletions
Large diffs are not rendered by default.

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers.CodeFixes/Helpers/CustomFixAllProviders.cs

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
2+
// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
3+
4+
namespace AsyncUsageAnalyzers.Helpers
5+
{
6+
using Microsoft.CodeAnalysis.CodeActions;
7+
using Microsoft.CodeAnalysis.CodeFixes;
8+
9+
/// <summary>
10+
/// Contains custom implementations of <see cref="FixAllProvider"/>.
11+
/// </summary>
12+
internal static class CustomFixAllProviders
13+
{
14+
/// <summary>
15+
/// Gets the default batch fix all provider.
16+
/// This provider batches all the individual diagnostic fixes across the scope of fix all action,
17+
/// computes fixes in parallel and then merges all the non-conflicting fixes into a single fix all code action.
18+
/// This fixer supports fixes for the following fix all scopes:
19+
/// <see cref="FixAllScope.Document"/>, <see cref="FixAllScope.Project"/> and <see cref="FixAllScope.Solution"/>.
20+
/// </summary>
21+
/// <remarks>
22+
/// The batch fix all provider only batches operations (i.e. <see cref="CodeActionOperation"/>) of type
23+
/// <see cref="ApplyChangesOperation"/> present within the individual diagnostic fixes. Other types of
24+
/// operations present within these fixes are ignored.
25+
/// </remarks>
26+
/// <value>
27+
/// The default batch fix all provider.
28+
/// </value>
29+
public static FixAllProvider BatchFixer => CustomBatchFixAllProvider.Instance;
30+
}
31+
}

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers.CodeFixes/Helpers/FixAllContextHelper.cs

Lines changed: 307 additions & 0 deletions
Large diffs are not rendered by default.

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers.CodeFixes/Naming/AvoidAsyncSuffixCodeFixProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ internal class AvoidAsyncSuffixCodeFixProvider : CodeFixProvider
2424
/// <inheritdoc/>
2525
public override FixAllProvider GetFixAllProvider()
2626
{
27-
return WellKnownFixAllProviders.BatchFixer;
27+
return CustomFixAllProviders.BatchFixer;
2828
}
2929

3030
/// <inheritdoc/>

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers.CodeFixes/Naming/UseAsyncSuffixCodeFixProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ internal class UseAsyncSuffixCodeFixProvider : CodeFixProvider
2424
/// <inheritdoc/>
2525
public override FixAllProvider GetFixAllProvider()
2626
{
27-
return WellKnownFixAllProviders.BatchFixer;
27+
return CustomFixAllProviders.BatchFixer;
2828
}
2929

3030
/// <inheritdoc/>

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers.CodeFixes/Usage/UseConfigureAwaitCodeFixProvider.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using System.Composition;
55
using System.Threading;
66
using System.Threading.Tasks;
7+
using Helpers;
78
using Microsoft.CodeAnalysis;
89
using Microsoft.CodeAnalysis.CodeActions;
910
using Microsoft.CodeAnalysis.CodeFixes;
@@ -27,7 +28,7 @@ internal class UseConfigureAwaitCodeFixProvider : CodeFixProvider
2728
/// <inheritdoc/>
2829
public override FixAllProvider GetFixAllProvider()
2930
{
30-
return WellKnownFixAllProviders.BatchFixer;
31+
return CustomFixAllProviders.BatchFixer;
3132
}
3233

3334
/// <inheritdoc/>

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers/AsyncUsageAnalyzers.csproj

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,12 @@
4848
<Compile Include="AnalyzerExtensions.cs" />
4949
<Compile Include="ExcludeFromCodeCoverageAttribute.cs" />
5050
<Compile Include="GeneratedCodeAnalysisExtensions.cs" />
51+
<Compile Include="Helpers\HelpersResources.Designer.cs">
52+
<AutoGen>True</AutoGen>
53+
<DesignTime>True</DesignTime>
54+
<DependentUpon>HelpersResources.resx</DependentUpon>
55+
</Compile>
56+
<Compile Include="Helpers\SpecializedTasks.cs" />
5157
<Compile Include="Helpers\TriviaHelper.cs" />
5258
<Compile Include="Naming\AvoidAsyncSuffixAnalyzer.cs" />
5359
<Compile Include="Naming\NamingResources.Designer.cs">
@@ -77,6 +83,10 @@
7783
<Compile Include="Usage\UseConfigureAwaitAnalyzer.cs" />
7884
</ItemGroup>
7985
<ItemGroup>
86+
<EmbeddedResource Include="Helpers\HelpersResources.resx">
87+
<Generator>ResXFileCodeGenerator</Generator>
88+
<LastGenOutput>HelpersResources.Designer.cs</LastGenOutput>
89+
</EmbeddedResource>
8090
<EmbeddedResource Include="Naming\NamingResources.resx">
8191
<Generator>ResXFileCodeGenerator</Generator>
8292
<LastGenOutput>NamingResources.Designer.cs</LastGenOutput>

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers/Helpers/HelpersResources.Designer.cs

Lines changed: 91 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎AsyncUsageAnalyzers/AsyncUsageAnalyzers/Helpers/HelpersResources.resx

Lines changed: 129 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,129 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<root>
3+
<!--
4+
Microsoft ResX Schema
5+
6+
Version 2.0
7+
8+
The primary goals of this format is to allow a simple XML format
9+
that is mostly human readable. The generation and parsing of the
10+
various data types are done through the TypeConverter classes
11+
associated with the data types.
12+
13+
Example:
14+
15+
... ado.net/XML headers & schema ...
16+
<resheader name="resmimetype">text/microsoft-resx</resheader>
17+
<resheader name="version">2.0</resheader>
18+
<resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
19+
<resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
20+
<data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
21+
<data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
22+
<data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
23+
<value>[base64 mime encoded serialized .NET Framework object]</value>
24+
</data>
25+
<data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
26+
<value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
27+
<comment>This is a comment</comment>
28+
</data>
29+
30+
There are any number of "resheader" rows that contain simple
31+
name/value pairs.
32+
33+
Each data row contains a name, and value. The row also contains a
34+
type or mimetype. Type corresponds to a .NET class that support
35+
text/value conversion through the TypeConverter architecture.
36+
Classes that don't support this are serialized and stored with the
37+
mimetype set.
38+
39+
The mimetype is used for serialized objects, and tells the
40+
ResXResourceReader how to depersist the object. This is currently not
41+
extensible. For a given mimetype the value must be set accordingly:
42+
43+
Note - application/x-microsoft.net.object.binary.base64 is the format
44+
that the ResXResourceWriter will generate, however the reader can
45+
read any of the formats listed below.
46+
47+
mimetype: application/x-microsoft.net.object.binary.base64
48+
value : The object must be serialized with
49+
: System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
50+
: and then encoded with base64 encoding.
51+
52+
mimetype: application/x-microsoft.net.object.soap.base64
53+
value : The object must be serialized with
54+
: System.Runtime.Serialization.Formatters.Soap.SoapFormatter
55+
: and then encoded with base64 encoding.
56+
57+
mimetype: application/x-microsoft.net.object.bytearray.base64
58+
value : The object must be serialized into a byte array
59+
: using a System.ComponentModel.TypeConverter
60+
: and then encoded with base64 encoding.
61+
-->
62+
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
63+
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
64+
<xsd:element name="root" msdata:IsDataSet="true">
65+
<xsd:complexType>
66+
<xsd:choice maxOccurs="unbounded">
67+
<xsd:element name="metadata">
68+
<xsd:complexType>
69+
<xsd:sequence>
70+
<xsd:element name="value" type="xsd:string" minOccurs="0" />
71+
</xsd:sequence>
72+
<xsd:attribute name="name" use="required" type="xsd:string" />
73+
<xsd:attribute name="type" type="xsd:string" />
74+
<xsd:attribute name="mimetype" type="xsd:string" />
75+
<xsd:attribute ref="xml:space" />
76+
</xsd:complexType>
77+
</xsd:element>
78+
<xsd:element name="assembly">
79+
<xsd:complexType>
80+
<xsd:attribute name="alias" type="xsd:string" />
81+
<xsd:attribute name="name" type="xsd:string" />
82+
</xsd:complexType>
83+
</xsd:element>
84+
<xsd:element name="data">
85+
<xsd:complexType>
86+
<xsd:sequence>
87+
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
88+
<xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
89+
</xsd:sequence>
90+
<xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
91+
<xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
92+
<xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
93+
<xsd:attribute ref="xml:space" />
94+
</xsd:complexType>
95+
</xsd:element>
96+
<xsd:element name="resheader">
97+
<xsd:complexType>
98+
<xsd:sequence>
99+
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
100+
</xsd:sequence>
101+
<xsd:attribute name="name" type="xsd:string" use="required" />
102+
</xsd:complexType>
103+
</xsd:element>
104+
</xsd:choice>
105+
</xsd:complexType>
106+
</xsd:element>
107+
</xsd:schema>
108+
<resheader name="resmimetype">
109+
<value>text/microsoft-resx</value>
110+
</resheader>
111+
<resheader name="version">
112+
<value>2.0</value>
113+
</resheader>
114+
<resheader name="reader">
115+
<value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
116+
</resheader>
117+
<resheader name="writer">
118+
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
119+
</resheader>
120+
<data name="FixAllOccurrencesOfDiagnostic" xml:space="preserve">
121+
<value>Fix all '{0}'</value>
122+
</data>
123+
<data name="FixAllOccurrencesOfDiagnosticInScope" xml:space="preserve">
124+
<value>Fix all '{0}' in '{1}'</value>
125+
</data>
126+
<data name="FixAllOccurrencesOfDiagnosticInSolution" xml:space="preserve">
127+
<value>Fix all '{0}' in Solution</value>
128+
</data>
129+
</root>

0 commit comments

Comments
 (0)