REFL023 The type does not implement the interface. #23

Author: JohanLarsson

README.md

@@ -80,5 +80,9 @@ Analyzers checking System.Reflection
     <td><a href="https://github.com/DotNetAnalyzers/ReflectionAnalyzers/tree/master/documentation/REFL020.md">REFL020</a></td>
     <td>More than one interface is matching the name.</td>
   </tr>
+  <tr>
+    <td><a href="https://github.com/DotNetAnalyzers/ReflectionAnalyzers/tree/master/documentation/REFL023.md">REFL023</a></td>
+    <td>The type does not implement the interface.</td>
+  </tr>
 <table>
 <!-- end generated table -->

ReflectionAnalyzers.Tests/REFL023TypeDoesNotImplementInterfaceTests/Diagnostics.cs

@@ -0,0 +1,36 @@
+namespace ReflectionAnalyzers.Tests.REFL023TypeDoesNotImplementInterfaceTests
+{
+    using Gu.Roslyn.Asserts;
+    using Microsoft.CodeAnalysis.Diagnostics;
+    using NUnit.Framework;
+
+    public class Diagnostics
+    {
+        private static readonly DiagnosticAnalyzer Analyzer = new GetInterfaceAnalyzer();
+        private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create(REFL023TypeDoesNotImplementInterface.Descriptor);
+
+        [TestCase("GetInterface(↓\"System.Collections.Generic.IEnumerable`1\")")]
+        [TestCase("GetInterface(↓\"IEnumerable`1\")")]
+        [TestCase("GetInterface(typeof(IEnumerable<>).FullName)")]
+        public void GetInterface(string call)
+        {
+            var code = @"
+namespace RoslynSandbox
+{
+    using System;
+    using System.Collections;
+    using System.Collections.Generic;
+
+    public class Foo
+    {
+        public Foo()
+        {
+            var type = typeof(Foo).GetInterface(↓""System.Collections.Generic.IEnumerable`1"");
+        }
+    }
+}".AssertReplace("GetInterface(↓\"System.Collections.Generic.IEnumerable`1\")", call);
+
+            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, code);
+        }
+    }
+}

ReflectionAnalyzers.Tests/REFL023TypeDoesNotImplementInterfaceTests/ValidCode.cs

@@ -0,0 +1,46 @@
+namespace ReflectionAnalyzers.Tests.REFL023TypeDoesNotImplementInterfaceTests
+{
+    using Gu.Roslyn.Asserts;
+    using Microsoft.CodeAnalysis.Diagnostics;
+    using NUnit.Framework;
+
+    public class ValidCode
+    {
+        private static readonly DiagnosticAnalyzer Analyzer = new GetInterfaceAnalyzer();
+        private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create(REFL023TypeDoesNotImplementInterface.Descriptor);
+
+        [TestCase("GetInterface(\"System.Collections.Generic.IEnumerable`1\")")]
+        [TestCase("GetInterface(\"IEnumerable`1\")")]
+        [TestCase("GetInterface(typeof(IEnumerable).FullName)")]
+        [TestCase("GetInterface(typeof(IEnumerable).Name)")]
+        [TestCase("GetInterface(typeof(IEnumerable<>).FullName)")]
+        [TestCase("GetInterface(typeof(IEnumerable<>).Name)")]
+        [TestCase("GetInterface(\"IEnumerable\")")]
+        [TestCase("GetInterface(\"System.Collections.IEnumerable\")")]
+        public void GetInterface(string call)
+        {
+            var code = @"
+namespace RoslynSandbox
+{
+    using System.Collections;
+    using System.Collections.Generic;
+
+    public class Foo : IEnumerable<int>
+    {
+        private readonly List<int> ints = new List<int>();
+
+        public Foo()
+        {
+            var type = typeof(Foo).GetInterface(""System.Collections.Generic.IEnumerable`1"");
+        }
+
+        public IEnumerator<int> GetEnumerator() => this.ints.GetEnumerator();
+
+        IEnumerator IEnumerable.GetEnumerator() => this.GetEnumerator();
+    }
+}".AssertReplace("GetInterface(\"System.Collections.Generic.IEnumerable`1\")", call);
+
+            AnalyzerAssert.Valid(Analyzer, ExpectedDiagnostic, code);
+        }
+    }
+}

ReflectionAnalyzers.sln

@@ -50,6 +50,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".docs", ".docs", "{1C271AF2
 		documentation\REFL018.md = documentation\REFL018.md
 		documentation\REFL019.md = documentation\REFL019.md
 		documentation\REFL020.md = documentation\REFL020.md
+		documentation\REFL023.md = documentation\REFL023.md
 		RELEASE_NOTES.md = RELEASE_NOTES.md
 	EndProjectSection
 EndProject

ReflectionAnalyzers/NodeAnalzers/GetInterfaceAnalyzer.cs

@@ -13,7 +13,8 @@ internal class GetInterfaceAnalyzer : DiagnosticAnalyzer
     {
         /// <inheritdoc/>
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create(
-            REFL020AmbiguousMatchInterface.Descriptor);
+            REFL020AmbiguousMatchInterface.Descriptor,
+            REFL023TypeDoesNotImplementInterface.Descriptor);
 
         /// <inheritdoc/>
         public override void Initialize(AnalysisContext context)
@@ -38,6 +39,11 @@ context.Node is InvocationExpressionSyntax invocation &&
                 {
                     context.ReportDiagnostic(Diagnostic.Create(REFL020AmbiguousMatchInterface.Descriptor, nameArg.GetLocation()));
                 }
+
+                if (count == 0)
+                {
+                    context.ReportDiagnostic(Diagnostic.Create(REFL023TypeDoesNotImplementInterface.Descriptor, nameArg.GetLocation()));
+                }
             }
 
             bool IsMatch(ITypeSymbol candidate)

ReflectionAnalyzers/REFL021TypeDoesNotExist.cs

@@ -0,0 +1,19 @@
+namespace ReflectionAnalyzers
+{
+    using Microsoft.CodeAnalysis;
+
+    internal static class REFL021TypeDoesNotExist
+    {
+        public const string DiagnosticId = "REFL021";
+
+        internal static readonly DiagnosticDescriptor Descriptor = new DiagnosticDescriptor(
+            id: DiagnosticId,
+            title: "The type does not exist.",
+            messageFormat: "The type does not exist.",
+            category: AnalyzerCategory.SystemReflection,
+            defaultSeverity: DiagnosticSeverity.Warning,
+            isEnabledByDefault: true,
+            description: "The type does not exist.",
+            helpLinkUri: HelpLink.ForId(DiagnosticId));
+    }
+}

ReflectionAnalyzers/REFL022UseFullyQualifiedName.cs

@@ -0,0 +1,19 @@
+namespace ReflectionAnalyzers
+{
+    using Microsoft.CodeAnalysis;
+
+    internal static class REFL022UseFullyQualifiedName
+    {
+        public const string DiagnosticId = "REFL022";
+
+        internal static readonly DiagnosticDescriptor Descriptor = new DiagnosticDescriptor(
+            id: DiagnosticId,
+            title: "Use fully qualified name.",
+            messageFormat: "Use fully qualified name {0}.",
+            category: AnalyzerCategory.SystemReflection,
+            defaultSeverity: DiagnosticSeverity.Warning,
+            isEnabledByDefault: true,
+            description: "Use fully qualified name.",
+            helpLinkUri: HelpLink.ForId(DiagnosticId));
+    }
+}

ReflectionAnalyzers/REFL023TypeDoesNotImplementInterface.cs

@@ -0,0 +1,19 @@
+namespace ReflectionAnalyzers
+{
+    using Microsoft.CodeAnalysis;
+
+    internal static class REFL023TypeDoesNotImplementInterface
+    {
+        public const string DiagnosticId = "REFL023";
+
+        internal static readonly DiagnosticDescriptor Descriptor = new DiagnosticDescriptor(
+            id: DiagnosticId,
+            title: "The type does not implement the interface.",
+            messageFormat: "The type does not implement the interface.",
+            category: AnalyzerCategory.SystemReflection,
+            defaultSeverity: DiagnosticSeverity.Warning,
+            isEnabledByDefault: true,
+            description: "The type does not implement the interface.",
+            helpLinkUri: HelpLink.ForId(DiagnosticId));
+    }
+}

documentation/REFL023.md

@@ -0,0 +1,67 @@
+# REFL023
+## The type does not implement the interface.
+
+<!-- start generated table -->
+<table>
+  <tr>
+    <td>CheckId</td>
+    <td>REFL023</td>
+  </tr>
+  <tr>
+    <td>Severity</td>
+    <td>Warning</td>
+  </tr>
+  <tr>
+    <td>Enabled</td>
+    <td>true</td>
+  </tr>
+  <tr>
+    <td>Category</td>
+    <td>ReflectionAnalyzers.SystemReflection</td>
+  </tr>
+  <tr>
+    <td>Code</td>
+    <td><a href="https://github.com/DotNetAnalyzers/ReflectionAnalyzers/blob/master/ReflectionAnalyzers/NodeAnalzers/GetInterfaceAnalyzer.cs">GetInterfaceAnalyzer</a></td>
+  </tr>
+</table>
+<!-- end generated table -->
+
+## Description
+
+The type does not implement the interface.
+
+## Motivation
+
+ADD MOTIVATION HERE
+
+## How to fix violations
+
+ADD HOW TO FIX VIOLATIONS HERE
+
+<!-- start generated config severity -->
+## Configure severity
+
+### Via ruleset file.
+
+Configure the severity per project, for more info see [MSDN](https://msdn.microsoft.com/en-us/library/dd264949.aspx).
+
+### Via #pragma directive.
+```C#
+#pragma warning disable REFL023 // The type does not implement the interface.
+Code violating the rule here
+#pragma warning restore REFL023 // The type does not implement the interface.
+```
+
+Or put this at the top of the file to disable all instances.
+```C#
+#pragma warning disable REFL023 // The type does not implement the interface.
+```
+
+### Via attribute `[SuppressMessage]`.
+
+```C#
+[System.Diagnostics.CodeAnalysis.SuppressMessage("ReflectionAnalyzers.SystemReflection", 
+    "REFL023:The type does not implement the interface.", 
+    Justification = "Reason...")]
+```
+<!-- end generated config severity -->