Failing tests.

Author: JohanLarsson

ReflectionAnalyzers.Tests/REFL003MemberDoesNotExistTests/Diagnostics.cs

@@ -133,17 +133,17 @@ class Foo
     {
         public Foo()
         {
-            var member = typeof(CustomAggregateException).GetField(""value"", BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Instance | BindingFlags.DeclaredOnly);
+            var member = typeof(CustomAggregateException).GetField(""MISSING"", BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Instance | BindingFlags.DeclaredOnly);
         }
     }
 }";
 
-            AnalyzerAssert.Valid(Analyzer, ExpectedDiagnostic, exception, code);
+            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, exception, code);
         }
 
-        [TestCase("GetNestedType(\"Generic\", BindingFlags.Public)")]
-        [TestCase("GetNestedType(nameof(Generic<int>), BindingFlags.Public)")]
-        [TestCase("GetNestedType(\"Generic`2\", BindingFlags.Public)")]
+        [TestCase("GetNestedType(↓\"Generic\", BindingFlags.Public)")]
+        [TestCase("GetNestedType(↓nameof(Generic<int>), BindingFlags.Public)")]
+        [TestCase("GetNestedType(↓\"Generic`2\", BindingFlags.Public)")]
         public void GetNestedType(string call)
         {
             var code = @"
@@ -155,15 +155,15 @@ class Foo
     {
         public Foo()
         {
-            var methodInfo = typeof(Foo).GetNestedType(nameof(Generic<int>), BindingFlags.Public);
+            var methodInfo = typeof(Foo).GetNestedType(↓nameof(Generic<int>), BindingFlags.Public);
         }
 
         public class Generic<T>
         {
         }
     }
-}".AssertReplace("GetNestedType(nameof(Generic<int>), BindingFlags.Public)", call);
-            AnalyzerAssert.Valid(Analyzer, ExpectedDiagnostic, code);
+}".AssertReplace("GetNestedType(↓nameof(Generic<int>), BindingFlags.Public)", call);
+            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, code);
         }
     }
 }

ReflectionAnalyzers.Tests/REFL005WrongBindingFlagsTests/CodeFix.cs

@@ -10,7 +10,7 @@ internal class CodeFix
     {
         private static readonly DiagnosticAnalyzer Analyzer = new GetXAnalyzer();
         private static readonly CodeFixProvider Fix = new BindingFlagsFix();
-        private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create("REFL005");
+        private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create(REFL005WrongBindingFlags.Descriptor);
 
         [TestCase("Static",           "BindingFlags.Public | BindingFlags.Instance",                                "BindingFlags.Public | BindingFlags.Static | BindingFlags.DeclaredOnly")]
         [TestCase("Static",           "BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly",    "BindingFlags.Public | BindingFlags.Static | BindingFlags.DeclaredOnly")]

ReflectionAnalyzers.Tests/REFL005WrongBindingFlagsTests/Diagnostics.cs

@@ -0,0 +1,36 @@
+namespace ReflectionAnalyzers.Tests.REFL005WrongBindingFlagsTests
+{
+    using Gu.Roslyn.Asserts;
+    using Microsoft.CodeAnalysis.Diagnostics;
+    using NUnit.Framework;
+
+    internal class Diagnostics
+    {
+        private static readonly DiagnosticAnalyzer Analyzer = new GetXAnalyzer();
+        private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create(REFL005WrongBindingFlags.Descriptor);
+
+        [TestCase("GetConstructor(↓Type.EmptyTypes)")]
+        [TestCase("GetConstructor(↓Array.Empty<Type>())")]
+        [TestCase("GetConstructor(↓new Type[0])")]
+        [TestCase("GetConstructor(↓new Type[1] { typeof(double) })")]
+        [TestCase("GetConstructor(↓new Type[] { typeof(double) })")]
+        [TestCase("GetConstructor(↓new[] { typeof(double) })")]
+        public void GetConstructor(string call)
+        {
+            var code = @"
+namespace RoslynSandbox
+{
+    using System;
+
+    public class Foo
+    {
+        public Foo(int value)
+        {
+            var ctor = typeof(Foo).GetConstructor(↓Type.EmptyTypes);
+        }
+    }
+}".AssertReplace("GetConstructor(↓Type.EmptyTypes)", call);
+            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, code);
+        }
+    }
+}

ReflectionAnalyzers.Tests/REFL005WrongBindingFlagsTests/ValidCode.cs

@@ -7,7 +7,7 @@ namespace ReflectionAnalyzers.Tests.REFL005WrongBindingFlagsTests
     internal class ValidCode
     {
         private static readonly DiagnosticAnalyzer Analyzer = new GetXAnalyzer();
-        private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create("REFL005");
+        private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create(REFL005WrongBindingFlags.Descriptor);
 
         [TestCase("GetMethod(nameof(Static))")]
         [TestCase("GetMethod(nameof(Static), BindingFlags.Public | BindingFlags.Static)")]