Fixed unit test to properly use the 'systemUsingDirectivesFirst' setting

Author: vweijsters

StyleCop.Analyzers/StyleCop.Analyzers.Test/OrderingRules/SA1217UnitTests.cs

@@ -19,7 +19,17 @@ public class SA1217UnitTests
 {
   ""settings"": {
     ""orderingRules"": {
-      ""systemUsingDirectivesFirst"": ""true""
+      ""systemUsingDirectivesFirst"": true
+    }
+  }
+}
+";
+
+        private const string TestSettingsNoSystemDirectivesFirst = @"
+{
+  ""settings"": {
+    ""orderingRules"": {
+      ""systemUsingDirectivesFirst"": false
     }
   }
 }
@@ -203,8 +213,8 @@ public async Task TestInvalidUsingDirectivesWithGlobalPrefixAsync()
         public async Task TestPreprocessorDirectivesAsync()
         {
             var testCode = @"
-using System;
 using Microsoft.Win32;
+using System;
 using MyList = System.Collections.Generic.List<int>;
 using static System.Tuple;
 
@@ -217,8 +227,8 @@ public async Task TestPreprocessorDirectivesAsync()
 #endif";
 
             var fixedTestCode = @"
-using System;
 using Microsoft.Win32;
+using System;
 using static System.Tuple;
 using MyList = System.Collections.Generic.List<int>;
 
@@ -295,7 +305,7 @@ private Task VerifyCSharpDiagnosticAsync(string source, DiagnosticResult[] expec
             var test = new StyleCopCodeFixVerifier<SA1217UsingStaticDirectivesMustBeOrderedAlphabetically, UsingCodeFixProvider>.CSharpTest
             {
                 TestCode = source,
-                Settings = this.useSystemUsingDirectivesFirst ? TestSettings : null,
+                Settings = this.useSystemUsingDirectivesFirst ? TestSettings : TestSettingsNoSystemDirectivesFirst,
             };
 
             test.ExpectedDiagnostics.AddRange(expected);
@@ -308,7 +318,7 @@ private Task VerifyCSharpFixAsync(string source, DiagnosticResult[] expected, st
             {
                 TestCode = source,
                 FixedCode = fixedSource,
-                Settings = this.useSystemUsingDirectivesFirst ? TestSettings : null,
+                Settings = this.useSystemUsingDirectivesFirst ? TestSettings : TestSettingsNoSystemDirectivesFirst,
             };
 
             test.ExpectedDiagnostics.AddRange(expected);