Use static lambdas

Author: RehanSaeed

Source/Boxed.AspNetCore.Swagger/OperationFilters/ClaimsOperationFilter.cs

@@ -33,7 +33,7 @@ public void Apply(OpenApiOperation operation, OperationFilterContext context)
         var authorizationRequirements = filterDescriptors.GetPolicyRequirements();
         var claimTypes = authorizationRequirements
             .OfType<ClaimsAuthorizationRequirement>()
-            .Select(x => x.ClaimType)
+            .Select(static x => x.ClaimType)
             .ToList();
         if (claimTypes.Any())
         {

Source/Boxed.AspNetCore/ServiceCollectionExtensions.cs

@@ -101,7 +101,7 @@ public static IServiceCollection ConfigureSingleton<TOptions>(
 
         return services
             .Configure<TOptions>(configuration)
-            .AddSingleton(x => x.GetRequiredService<IOptions<TOptions>>().Value);
+            .AddSingleton(static x => x.GetRequiredService<IOptions<TOptions>>().Value);
     }
 
     /// <summary>
@@ -123,7 +123,7 @@ public static IServiceCollection ConfigureSingleton<TOptions>(
 
         return services
             .Configure<TOptions>(configuration, configureBinder)
-            .AddSingleton(x => x.GetRequiredService<IOptions<TOptions>>().Value);
+            .AddSingleton(static x => x.GetRequiredService<IOptions<TOptions>>().Value);
     }
 
     /// <summary>
@@ -147,7 +147,7 @@ public static IServiceCollection ConfigureAndValidateSingleton<TOptions>(
             .Bind(configuration)
             .ValidateDataAnnotations()
             .ValidateOnStart();
-        return services.AddSingleton(x => x.GetRequiredService<IOptions<TOptions>>().Value);
+        return services.AddSingleton(static x => x.GetRequiredService<IOptions<TOptions>>().Value);
     }
 
     /// <summary>
@@ -173,7 +173,7 @@ public static IServiceCollection ConfigureAndValidateSingleton<TOptions>(
             .Bind(configuration, configureBinder)
             .ValidateDataAnnotations()
             .ValidateOnStart();
-        return services.AddSingleton(x => x.GetRequiredService<IOptions<TOptions>>().Value);
+        return services.AddSingleton(static x => x.GetRequiredService<IOptions<TOptions>>().Value);
     }
 
     /// <summary>
@@ -201,7 +201,7 @@ public static IServiceCollection ConfigureAndValidateSingleton<TOptions>(
             .ValidateDataAnnotations()
             .Validate(validation)
             .ValidateOnStart();
-        return services.AddSingleton(x => x.GetRequiredService<IOptions<TOptions>>().Value);
+        return services.AddSingleton(static x => x.GetRequiredService<IOptions<TOptions>>().Value);
     }
 
     /// <summary>
@@ -231,7 +231,7 @@ public static IServiceCollection ConfigureAndValidateSingleton<TOptions>(
             .ValidateDataAnnotations()
             .Validate(validation)
             .ValidateOnStart();
-        return services.AddSingleton(x => x.GetRequiredService<IOptions<TOptions>>().Value);
+        return services.AddSingleton(static x => x.GetRequiredService<IOptions<TOptions>>().Value);
     }
 
     /// <summary>
@@ -262,7 +262,7 @@ public static IServiceCollection ConfigureAndValidateSingleton<TOptions>(
             .ValidateDataAnnotations()
             .Validate(validation, failureMessage)
             .ValidateOnStart();
-        return services.AddSingleton(x => x.GetRequiredService<IOptions<TOptions>>().Value);
+        return services.AddSingleton(static x => x.GetRequiredService<IOptions<TOptions>>().Value);
     }
 
     /// <summary>
@@ -295,6 +295,6 @@ public static IServiceCollection ConfigureAndValidateSingleton<TOptions>(
             .ValidateDataAnnotations()
             .Validate(validation, failureMessage)
             .ValidateOnStart();
-        return services.AddSingleton(x => x.GetRequiredService<IOptions<TOptions>>().Value);
+        return services.AddSingleton(static x => x.GetRequiredService<IOptions<TOptions>>().Value);
     }
 }

Source/Boxed.DotnetNewTest/AssemblyResolver.cs

@@ -64,7 +64,7 @@ bool NamesMatch(RuntimeLibrary runtime) =>
                 library.Name,
                 library.Version,
                 library.Hash,
-                library.RuntimeAssemblyGroups.SelectMany(g => g.AssetPaths),
+                library.RuntimeAssemblyGroups.SelectMany(static g => g.AssetPaths),
                 library.Dependencies,
                 library.Serviceable);
 

Source/Boxed.DotnetNewTest/ConfigurationService.cs

@@ -23,8 +23,8 @@ public static string GetTempDirectoryPath()
         // Don't want to overwork my SSD drive, so use the D drive where available.
         var drivePath = DriveInfo
             .GetDrives()
-            .Where(x => x.DriveType == DriveType.Fixed)
-            .OrderByDescending(x => string.Equals(x.Name, @"D:\", StringComparison.Ordinal))
+            .Where(static x => x.DriveType == DriveType.Fixed)
+            .OrderByDescending(static x => string.Equals(x.Name, @"D:\", StringComparison.Ordinal))
             .FirstOrDefault()
             ?.Name;
         if (drivePath is null)

Source/Boxed.DotnetNewTest/DirectoryExtensions.cs

@@ -79,7 +79,7 @@ public static string GetTempDirectoryPath() =>
     /// <returns>A short temporary directory path.</returns>
     public static string GetShortTempDirectoryPath() =>
         Path.Combine(
-            DriveInfo.GetDrives().First(x => x.DriveType == DriveType.Fixed).RootDirectory.FullName,
+            DriveInfo.GetDrives().First(static x => x.DriveType == DriveType.Fixed).RootDirectory.FullName,
             "Temp",
             Guid.NewGuid().ToString().Replace("-", string.Empty, StringComparison.Ordinal));
 

Source/Boxed.DotnetNewTest/DotnetNew.cs

@@ -146,7 +146,7 @@ private static string GetProjectFilePath(Assembly assembly, string fileName)
             projectFilePath = directory
                 .Parent
                 .GetFiles(projectName, SearchOption.AllDirectories)
-                .FirstOrDefault(x => !IsInObjDirectory(x.Directory))
+                .FirstOrDefault(static x => !IsInObjDirectory(x.Directory))
                 ?.FullName;
             if (projectFilePath is not null)
             {