Skip to content

Commit 8f5d063

Browse files
committed
Changes based on reviewer comments.
1 parent 339cfc7 commit 8f5d063

File tree

3 files changed

+34
-2
lines changed

3 files changed

+34
-2
lines changed

modules/rostests/winetests/riched20/editor.c

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9022,6 +9022,38 @@ static void test_EM_SELECTIONTYPE(void)
90229022
DestroyWindow(hwnd);
90239023
}
90249024

9025+
static void test_window_classes(void)
9026+
{
9027+
static const struct
9028+
{
9029+
const char *class;
9030+
BOOL success;
9031+
} test[] =
9032+
{
9033+
{ "RichEdit", FALSE },
9034+
{ "RichEdit20A", TRUE },
9035+
{ "RichEdit20W", TRUE },
9036+
{ "RichEdit50A", FALSE },
9037+
{ "RichEdit50W", FALSE }
9038+
};
9039+
int i;
9040+
HWND hwnd;
9041+
9042+
for (i = 0; i < sizeof(test)/sizeof(test[0]); i++)
9043+
{
9044+
SetLastError(0xdeadbeef);
9045+
hwnd = CreateWindowExA(0, test[i].class, NULL, WS_POPUP, 0, 0, 0, 0, 0, 0, 0, NULL);
9046+
todo_wine_if(!strcmp(test[i].class, "RichEdit50A") || !strcmp(test[i].class, "RichEdit50W"))
9047+
ok(!hwnd == !test[i].success, "CreateWindow(%s) should %s\n",
9048+
test[i].class, test[i].success ? "succeed" : "fail");
9049+
if (!hwnd)
9050+
todo_wine
9051+
ok(GetLastError() == ERROR_CANNOT_FIND_WND_CLASS, "got %d\n", GetLastError());
9052+
else
9053+
DestroyWindow(hwnd);
9054+
}
9055+
}
9056+
90259057
START_TEST( editor )
90269058
{
90279059
BOOL ret;
@@ -9031,6 +9063,7 @@ START_TEST( editor )
90319063
ok(hmoduleRichEdit != NULL, "error: %d\n", (int) GetLastError());
90329064
is_lang_japanese = (PRIMARYLANGID(GetSystemDefaultLangID()) == LANG_JAPANESE);
90339065

9066+
test_window_classes();
90349067
test_WM_CHAR();
90359068
test_EM_FINDTEXT(FALSE);
90369069
test_EM_FINDTEXT(TRUE);

modules/rostests/winetests/riched20/txtsrv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ static PCreateTextServices pCreateTextServices;
4848

4949
/* Use a special table for x86 machines to convert the thiscall
5050
* calling convention. This isn't needed on other platforms. */
51-
#if defined(__i386__) && !defined(__MINGW32__) && (!defined(_MSC_VER) || !defined(__clang__))
51+
#if defined(__i386__) && !defined(__MINGW32__) && (!defined(_MSC_VER) || !defined(__clang__))
5252
static ITextServicesVtbl itextServicesStdcallVtbl;
5353
#define TXTSERV_VTABLE(This) (&itextServicesStdcallVtbl)
5454
#else /* __i386__ */

sdk/include/psdk/textserv.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,4 +452,3 @@ typedef HRESULT (WINAPI *PCreateTextServices)(IUnknown*,ITextHost*,IUnknown**);
452452
#endif
453453

454454
#endif /* _TEXTSERV_H */
455-

0 commit comments

Comments
 (0)