Changes based on reviewer comments.

Doug-Lyons · Doug-Lyons · commit cb977b26224e · 2025-01-19T18:49:28.000-06:00
diff --git a/dll/win32/shell32/shlexec.cpp b/dll/win32/shell32/shlexec.cpp
@@ -803,7 +803,7 @@ static UINT SHELL_FindExecutable(LPCWSTR lpPath, LPCWSTR lpFile, LPCWSTR lpVerb,
     }
 
   /* Clear any trailing periods */
-  for (INT i = wcslen(xlpFile); i >= 0; i--)
+  for (SIZE_T i = wcslen(xlpFile);i > 0; i--)
   {
       if (i > 0 && xlpFile[i - 1] == '.')
           xlpFile[i - 1] = 0;

Original file line number	Diff line number	Diff line change
`@@ -803,7 +803,7 @@ static UINT SHELL_FindExecutable(LPCWSTR lpPath, LPCWSTR lpFile, LPCWSTR lpVerb,`
`803`	`803`	`}`
`804`	`804`
`805`	`805`	`/* Clear any trailing periods */`
`806`		`- for (INT i = wcslen(xlpFile); i >= 0; i--)`
	`806`	`+ for (SIZE_T i = wcslen(xlpFile);i > 0; i--)`
`807`	`807`	`{`
`808`	`808`	`if (i > 0 && xlpFile[i - 1] == '.')`
`809`	`809`	`xlpFile[i - 1] = 0;`