feat: replace use of undefined with optional param ?

david-roper · david-roper · commit 022e0c0d035c · 2025-08-06T16:08:01.000-04:00
diff --git a/apps/api/src/sessions/dto/create-session.dto.ts b/apps/api/src/sessions/dto/create-session.dto.ts
@@ -9,5 +9,5 @@ export class CreateSessionDto {
   groupId: null | string;
   subjectData: CreateSubjectData;
   type: SessionType;
-  userId: null | string | undefined;
+  userId?: null | string;
 }
diff --git a/apps/web/src/components/StartSessionForm/StartSessionForm.tsx b/apps/web/src/components/StartSessionForm/StartSessionForm.tsx
@@ -35,7 +35,7 @@ type StartSessionFormProps = {
   initialValues?: FormTypes.PartialNullableData<StartSessionFormData>;
   onSubmit: (data: CreateSessionData) => Promisable<void>;
   readOnly: boolean;
-  username: string | undefined;
+  username?: null | string;
 };
 
 export const StartSessionForm = ({

Original file line number	Diff line number	Diff line change
`@@ -9,5 +9,5 @@ export class CreateSessionDto {`
`9`	`9`	`groupId: null \| string;`
`10`	`10`	`subjectData: CreateSubjectData;`
`11`	`11`	`type: SessionType;`
`12`		`- userId: null \| string \| undefined;`
	`12`	`+ userId?: null \| string;`
`13`	`13`	`}`