fix: adjust removeSubjectIdScope methods to a shorter notation

Author: david-roper

apps/web/src/features/datahub/components/MasterDataTable.tsx

@@ -18,10 +18,7 @@ export const MasterDataTable = ({ data, onSelect }: MasterDataTableProps) => {
     <ClientTable<Subject>
       columns={[
         {
-          field: (subject) =>
-            subjectIdDisplaySetting
-              ? removeSubjectIdScope(subject.id).slice(0, subjectIdDisplaySetting)
-              : removeSubjectIdScope(subject.id).slice(0, 9),
+          field: (subject) => removeSubjectIdScope(subject.id).slice(0, subjectIdDisplaySetting ?? 9),
           label: t('datahub.index.table.subject')
         },
         {

apps/web/src/features/datahub/components/SubjectLayout.tsx

@@ -28,9 +28,7 @@ export const SubjectLayout = () => {
               en: 'Instrument Records for Subject {}',
               fr: "Dossiers d'instruments pour le client {}"
             },
-            subjectIdDisplaySetting
-              ? removeSubjectIdScope(subjectId).slice(0, subjectIdDisplaySetting)
-              : removeSubjectIdScope(subjectId).slice(0, 9)
+            removeSubjectIdScope(subjectId).slice(0, subjectIdDisplaySetting ?? 9)
           )}
         </Heading>
       </PageHeader>