fix: add comma to join to stop search working on mixed tags

david-roper · david-roper · commit 6cb363d8ec52 · 2025-05-12T14:49:25.000-04:00
diff --git a/apps/web/src/features/instruments/components/InstrumentShowcase/InstrumentShowcase.tsx b/apps/web/src/features/instruments/components/InstrumentShowcase/InstrumentShowcase.tsx
@@ -38,7 +38,7 @@ export const InstrumentShowcase: React.FC<{
       }
       return (
         details.title.toUpperCase().includes(searchTerm.toUpperCase()) ||
-        tags.join().toUpperCase().includes(searchTerm.toUpperCase())
+        tags.join(', ').toUpperCase().includes(searchTerm.toUpperCase())
       );
     });
     updatedFilteredInstruments.sort((a, b) => {

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ export const InstrumentShowcase: React.FC<{`
`38`	`38`	`}`
`39`	`39`	`return (`
`40`	`40`	`details.title.toUpperCase().includes(searchTerm.toUpperCase()) \|\|`
`41`		`- tags.join().toUpperCase().includes(searchTerm.toUpperCase())`
	`41`	`+ tags.join(', ').toUpperCase().includes(searchTerm.toUpperCase())`
`42`	`42`	`);`
`43`	`43`	`});`
`44`	`44`	`updatedFilteredInstruments.sort((a, b) => {`