Skip to content

Commit 2927eb5

Browse files
remove asset descriptors
1 parent e80878e commit 2927eb5

File tree

2 files changed

+0
-92
lines changed

2 files changed

+0
-92
lines changed

executor/source_managers/argocd_source_manager.py

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ def __init__(self):
3535
self.task_type_callable_map = {
3636
ArgoCD.TaskType.FETCH_DEPLOYMENT_INFO: {
3737
'executor': self.fetch_deployment_info,
38-
'asset_descriptor': self.argocd_application_asset_descriptor,
3938
'model_types': [SourceModelType.ARGOCD_APPS],
4039
'result_type': PlaybookTaskResultType.TABLE,
4140
'display_name': 'Fetch Latest Deployment Info',
@@ -222,36 +221,6 @@ def rollback_application(self, time_range: TimeRange, argocd_task: ArgoCD,
222221
def validate_command(argocd_task: ArgoCD):
223222
return "REQUIRES_APPROVAL"
224223

225-
@staticmethod
226-
def argocd_application_asset_descriptor(argocd_connector: ConnectorProto, filters: dict = None) -> str:
227-
try:
228-
assets: AccountConnectorAssets = asset_manager_facade.get_asset_model_values(argocd_connector,
229-
SourceModelType.ARGOCD_APPS,
230-
AccountConnectorAssetsModelFilters())
231-
if not assets:
232-
logger.warning(
233-
f"ArgoCDSourcesManager.argocd_application_asset_descriptor:: No assets found for connector"
234-
f" app : {argocd_connector.account_id.value}, and Connector: {argocd_connector.id.value}")
235-
return None
236-
237-
assets = assets[0]
238-
argocd_assets: [ArgoCDAppsAssetModel] = assets.argocd.assets
239-
all_app_asset: [ArgoCDAppsAssetModel] = [argocd_asset.argocd_apps for argocd_asset in argocd_assets if
240-
argocd_asset.type == SourceModelType.ARGOCD_APPS]
241-
asset_list_string = ""
242-
# TODO(VG: clean this up later)
243-
asset_list_string += "These are all the application deployments in ArgoCD. If a user-asked application contains more application within itself, then don't fetch information for these contained applications.: \n\n"
244-
for app_asset in all_app_asset:
245-
asset_list_string += f"{app_asset.name.value} has path {app_asset.path.value},\n"
246-
asset_list_string += "\n\n"
247-
return asset_list_string
248-
249-
except Exception as e:
250-
logger.error(f"ArgoCDSourcesManager.argocd_application_asset_descriptor:: Error while generating "
251-
f"asset descriptor for account: {argocd_connector.account_id.value} and connector: "
252-
f"{argocd_connector.id.value} with error: {e}")
253-
return None
254-
255224
def get_application_health(self, time_range: TimeRange, argocd_task: ArgoCD,
256225
argocd_connector: ConnectorProto) -> PlaybookTaskResult:
257226
try:

executor/source_managers/jira_source_manager.py

Lines changed: 0 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ def __init__(self):
2828
self.task_type_callable_map = {
2929
Jira.TaskType.CREATE_TICKET: {
3030
'executor': self.create_ticket,
31-
'asset_descriptor': self.jira_project_asset_descriptor,
3231
'model_types': [SourceModelType.JIRA_PROJECT],
3332
'result_type': PlaybookTaskResultType.API_RESPONSE,
3433
'display_name': 'Create JIRA Ticket',
@@ -91,7 +90,6 @@ def __init__(self):
9190
},
9291
Jira.TaskType.ASSIGN_TICKET: {
9392
'executor': self.assign_ticket,
94-
'asset_descriptor': self.jira_user_asset_descriptor,
9593
'model_types': [SourceModelType.JIRA_USER],
9694
'result_type': PlaybookTaskResultType.API_RESPONSE,
9795
'display_name': 'Assign JIRA Ticket',
@@ -147,7 +145,6 @@ def __init__(self):
147145
},
148146
Jira.TaskType.SEARCH_TICKETS: {
149147
'executor': self.search_tickets,
150-
'asset_descriptor': self.jira_project_asset_descriptor,
151148
'model_types': [SourceModelType.JIRA_PROJECT],
152149
'result_type': PlaybookTaskResultType.API_RESPONSE,
153150
'display_name': 'Search JIRA Tickets',
@@ -540,64 +537,6 @@ def search_tickets(self, time_range: TimeRange, jira_task: Jira,
540537
source=self.source
541538
)
542539

543-
@staticmethod
544-
def jira_project_asset_descriptor(jira_connector: ConnectorProto, filters: dict = None):
545-
try:
546-
assets: AccountConnectorAssets = asset_manager_facade.get_asset_model_values(jira_connector,
547-
SourceModelType.JIRA_PROJECT,
548-
AccountConnectorAssetsModelFilters())
549-
if not assets:
550-
logger.warning(f"JiraSourceManager.jira_project_asset_descriptor:: No assets found for "
551-
f"project: {jira_connector.account_id.value}, and Connector: {jira_connector.id.value}")
552-
assets = assets[0]
553-
jira_assets: [JiraProjectAssetModel] = assets.jira_cloud.assets
554-
all_project_asset: [JiraProjectAssetModel] = [jira_asset.jira_project for jira_asset in jira_assets if
555-
jira_asset.type == SourceModelType.JIRA_PROJECT]
556-
asset_list_string = ''
557-
for asset in all_project_asset:
558-
asset_list_string += f"project_name: `{asset.name.value}`, project_key: `{asset.key.value}`"
559-
asset_list_string += "\n\n"
560-
return asset_list_string
561-
except Exception as e:
562-
logger.error(f"JiraSourceManager.jira_project_asset_descriptor:: Error while generating "
563-
f"asset descriptor for account: {jira_connector.account_id.value} and connector: "
564-
f"{jira_connector.id.value} with error: {e}")
565-
return None
566-
567-
568-
@staticmethod
569-
def jira_user_asset_descriptor(jira_connector: ConnectorProto, filters: dict = None):
570-
try:
571-
assets: AccountConnectorAssets = asset_manager_facade.get_asset_model_values(
572-
jira_connector,
573-
SourceModelType.JIRA_USER,
574-
AccountConnectorAssetsModelFilters()
575-
)
576-
577-
if not assets:
578-
logger.warning(f"JiraSourceManager.jira_user_asset_descriptor:: No user assets found for "
579-
f"account: {jira_connector.account_id.value}, and Connector: {jira_connector.id.value}")
580-
return None
581-
582-
assets = assets[0]
583-
jira_users: [JiraUserAssetModel] = assets.jira_cloud.assets
584-
all_user_assets: [JiraUserAssetModel] = [jira_user for jira_user in jira_users if
585-
jira_user.type == SourceModelType.JIRA_USER]
586-
587-
asset_list_string = ''
588-
for asset in all_user_assets:
589-
asset_list_string += f"User name: `{asset.jira_user.display_name.value}` and Account ID: {asset.jira_user.account_id.value}"
590-
asset_list_string += "\n\n"
591-
592-
return asset_list_string
593-
594-
except Exception as e:
595-
logger.error(f"JiraSourceManager.jira_user_asset_descriptor:: Error while generating "
596-
f"user asset descriptor for account: {jira_connector.account_id.value} and connector: "
597-
f"{jira_connector.id.value} with error: {e}")
598-
599-
return None
600-
601540
@staticmethod
602541
def jira_project_user_summary(jira_connector: ConnectorProto, filters: dict = None):
603542
try:

0 commit comments

Comments
 (0)