Skip to content

Commit 88ed946

Browse files
authored
Arm backend: Update failures to slice operator for int16x8 (pytorch#15104)
### Summary Updates the x_fail message. Removes pytest.mark.fails from testcases and only fails on expected. cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai
1 parent 1489d4f commit 88ed946

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

backends/arm/test/ops/test_slice.py

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
from typing import Tuple
99

10-
import pytest
1110
import torch
1211
from executorch.backends.arm.quantizer.arm_quantizer import (
1312
get_symmetric_a16w8_quantization_config,
@@ -78,8 +77,8 @@ def test_slice_tensor_tosa_INT_nhwc(test_data: torch.Tensor):
7877

7978

8079
x_fails = {
81-
"ones_slice_3": "MLETORCH-1402: Slice operator has incorrect number of inputs",
82-
"ones_slice_4": "MLETORCH-1402: Slice operator has incorrect number of inputs",
80+
"ones_slice_3": "MLETORCH-1402: Compiler limitation when passing more than 255 char as argument to FVP.",
81+
"ones_slice_4": "MLETORCH-1402: Compiler limitation when passing more than 255 char as argument to FVP.",
8382
}
8483

8584

@@ -153,9 +152,6 @@ def get_symmetric_a16w8_slice_quantizer(per_channel_quantization=False):
153152

154153

155154
@common.parametrize("test_data", test_data_suite)
156-
@pytest.mark.xfail(
157-
reason="missing int16 slice ops support; fails at TOSA reference model with Unsupported operation type or rank. See: https://github.com/pytorch/executorch/issues/13976"
158-
)
159155
def test_slice_tensor_16a8w_tosa_INT(test_data: torch.Tensor):
160156
"""Test slice operation with 16A8W quantization (16-bit activations, 8-bit weights)"""
161157
per_channel_quantization = False
@@ -179,11 +175,8 @@ def test_slice_tensor_16a8w_tosa_INT(test_data: torch.Tensor):
179175
pipeline.run()
180176

181177

182-
@common.parametrize("test_data", test_data_suite)
178+
@common.parametrize("test_data", test_data_suite, x_fails)
183179
@common.XfailIfNoCorstone300
184-
@pytest.mark.xfail(
185-
reason="Vela compilation fails with 'Invalid arguments' for int16 slice operations"
186-
)
187180
def test_slice_tensor_16a8w_u55_INT16(test_data: torch.Tensor):
188181
"""Test slice operation with 16A8W quantization on U55 (16-bit activations, 8-bit weights)"""
189182
per_channel_quantization = False
@@ -206,11 +199,8 @@ def test_slice_tensor_16a8w_u55_INT16(test_data: torch.Tensor):
206199
pipeline.run()
207200

208201

209-
@common.parametrize("test_data", test_data_suite)
202+
@common.parametrize("test_data", test_data_suite, x_fails)
210203
@common.XfailIfNoCorstone320
211-
@pytest.mark.xfail(
212-
reason="Vela compilation fails with 'Invalid arguments' for int16 slice operations"
213-
)
214204
def test_slice_tensor_16a8w_u85_INT16(test_data: torch.Tensor):
215205
"""Test slice operation with 16A8W quantization on U85 (16-bit activations, 8-bit weights)"""
216206
per_channel_quantization = False

0 commit comments

Comments
 (0)