[1.21.1] Incorrect reactor behavior at high config scale factors #1988
Description
Base information
- Minecraft version: 1.21.1
- Mod version: 3.1.4.630
- Minecraft Forge version: Neoforge 21.1.216
- Mod Pack: FTB Stoneblock 4 version 1.5.0
Description / steps to reproduce
When operating a draconic reactor in Stoneblock 4, the containment field strength shown in the reactor GUI is inconsistent with the comparator output of a stabilizer set on either field strength mode. At a stable containment field strength of 65% as indicated by the GUI, a redstone comparator reading non-inverted field strength has an output value of 0. Allowing the containment field strength to fall below approximately 55% as indicated by the GUI while operating at a stable temperature of 7900C causes the reactor to instantaneously begin the meltdown sequence.
I believe the cause of this behavior is twofold. Primarily, the internal buffers for containment field strength and energy saturation are not resized when the reactorOutputMultiplier config value is changed; since Stoneblock 4 has this value set to 50, the internal containment field buffer is only large enough to hold one tick's worth of input energy. If the amount of energy in the buffer falls below the field input rate (which is very likely more than half the buffer's capacity), the buffer will momentarily be fully depleted when fieldDrain is subtracted from shieldCharge, resulting in the observed spontaneous meltdowns. Secondly, it seems the GUI and the redstone output compute field strength at different stages of computation within a tick: The redstone output and meltdown trigger are consistently pessimistic; and the GUI, textures, operating sound, and ComputerCraft API return values are consistently optimistic. Finally, the "Field Input Rate" value displayed in the GUI does not appear to be accurate: I have observed it to be nearly three times the actual input flow set by a flux gate at stable operating conditions similar to those stated above.