[TradingView] interrupt signal exec on invalid signal value

Author: GuillaumeDSM

Trading/Exchange/binance/binance_exchange.py

@@ -241,7 +241,7 @@ async def set_symbol_margin_type(self, symbol: str, isolated: bool, **kwargs: di
         :return: the update result
         """
         try:
-            return await super(). set_symbol_margin_type(symbol, isolated, **kwargs)
+            return await super().set_symbol_margin_type(symbol, isolated, **kwargs)
         except ccxt.ExchangeError as err:
             raise errors.NotSupported() from err
 

Trading/Mode/trading_view_signals_trading_mode/tests/test_trading_view_signals_trading.py

@@ -195,19 +195,20 @@ async def test_trading_view_signal_callback(tools):
     context = script_keywords.get_base_context(producer.trading_mode)
     with mock.patch.object(script_keywords, "get_base_context", mock.Mock(return_value=context)) \
          as get_base_context_mock:
-        # ensure exception is caught
-        with mock.patch.object(
-                producer, "signal_callback", mock.AsyncMock(side_effect=errors.MissingFunds)
-        ) as signal_callback_mock:
-            signal = f"""
-                EXCHANGE={exchange_manager.exchange_name}
-                SYMBOL={symbol}
-                SIGNAL=BUY
-            """
-            await mode._trading_view_signal_callback({"metadata": signal})
-            signal_callback_mock.assert_awaited_once()
-            get_base_context_mock.assert_called_once()
-            get_base_context_mock.reset_mock()
+        for exception in (errors.MissingFunds, errors.InvalidArgumentError):
+            # ensure exception is caught
+            with mock.patch.object(
+                    producer, "signal_callback", mock.AsyncMock(side_effect=exception)
+            ) as signal_callback_mock:
+                signal = f"""
+                    EXCHANGE={exchange_manager.exchange_name}
+                    SYMBOL={symbol}
+                    SIGNAL=BUY
+                """
+                await mode._trading_view_signal_callback({"metadata": signal})
+                signal_callback_mock.assert_awaited_once()
+                get_base_context_mock.assert_called_once()
+                get_base_context_mock.reset_mock()
 
         with mock.patch.object(producer, "signal_callback", mock.AsyncMock()) as signal_callback_mock:
             # invalid data
@@ -427,6 +428,23 @@ async def test_signal_callback(tools):
             }, context)
         _set_state_mock.assert_not_called()
 
+        with pytest.raises(errors.InvalidArgumentError):
+            await producer.signal_callback({
+                mode.EXCHANGE_KEY: exchange_manager.exchange_name,
+                mode.SYMBOL_KEY: "unused",
+                mode.SIGNAL_KEY: "DSDSDDSS",
+                mode.PRICE_KEY: "123000q",  # price = 123
+                mode.VOLUME_KEY: "11111b",  # base amount: not enough funds
+                mode.REDUCE_ONLY_KEY: True,
+                mode.ORDER_TYPE_SIGNAL: "LiMiT",
+                mode.STOP_PRICE_KEY: "-10%",  # price - 10%
+                mode.TAKE_PROFIT_PRICE_KEY: "120.333333333333333d",   # price  + 120.333333333333333
+                mode.EXCHANGE_ORDER_IDS: ["ab1", "aaaaa"],
+                "PARAM_TAG_1": "ttt",
+                "PARAM_Plop": False,
+            }, context)
+        _set_state_mock.assert_not_called()
+
 
 def compare_dict_with_nan(d_1, d_2):
     try:

Trading/Mode/trading_view_signals_trading_mode/trading_view_signals_trading.py

@@ -176,6 +176,8 @@ async def _trading_view_signal_callback(self, data):
                     (parsed_data[self.SYMBOL_KEY] == self.merged_simple_symbol or
                      parsed_data[self.SYMBOL_KEY] == self.str_symbol):
                 await self.producers[0].signal_callback(parsed_data, script_keywords.get_base_context(self))
+        except trading_errors.InvalidArgumentError as e:
+            self.logger.error(f"Error when handling trading view signal: {e}")
         except trading_errors.MissingFunds as e:
             self.logger.error(f"Error when handling trading view signal: not enough funds: {e}")
         except KeyError as e:
@@ -261,10 +263,9 @@ async def _parse_order_details(self, ctx, parsed_data):
         elif side == TradingViewSignalsTradingMode.CANCEL_SIGNAL:
             state = trading_enums.EvaluatorStates.NEUTRAL
         else:
-            self.logger.error(
+            raise trading_errors.InvalidArgumentError(
                 f"Unknown signal: {parsed_data[TradingViewSignalsTradingMode.SIGNAL_KEY]}, full data= {parsed_data}"
             )
-            state = trading_enums.EvaluatorStates.NEUTRAL
         target_price = 0 if order_type == TradingViewSignalsTradingMode.MARKET_SIGNAL else (
             await self._parse_price(ctx, parsed_data, TradingViewSignalsTradingMode.PRICE_KEY, 0))
         stop_price = await self._parse_price(