Skip to content

Commit b0191b8

Browse files
committed
[HollaEx] handle missing fees
1 parent 584428a commit b0191b8

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

Trading/Exchange/hollaex/hollaex_exchange.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,10 @@ def get_fees(self, symbol):
214214
fee_tiers = self._get_fee_tiers(self.exchange_manager.exchange, is_real_trading)
215215
return self._get_fees(self.exchange_manager.exchange_name, fee_tiers, symbol)
216216
except errors.MissingFeeDetailsError:
217-
self.logger.error(f"Missing fee details, using default value")
217+
if _EXCHANGE_FEE_TIERS_BY_EXCHANGE_NAME.get(self.exchange_manager.exchange_name):
218+
self.logger.error(f"Missing {self.exchange_manager.exchange_name} {symbol} fee details, using default value")
219+
else:
220+
self.logger.warning(f"Missing all {self.exchange_manager.exchange_name} fee details, using ccxt default values")
218221
market = self.get_market_status(symbol, with_fixer=False)
219222
# use default ccxt values
220223
return {
@@ -309,6 +312,11 @@ def _get_fetched_fees(cls, exchange: str, tier_to_use: FeeTiers, symbol: str):
309312
try:
310313
return exchange_fees[tier_to_use.value][symbol]
311314
except KeyError as err:
315+
if not exchange_fees:
316+
# mssing exchange fees, should not happen
317+
raise errors.MissingFeeDetailsError(
318+
f"Unexpected: missing {exchange} fee details"
319+
) from err
312320
if symbol not in exchange_fees[FeeTiers.BASIC.value]:
313321
default_fee_symbol = cls._get_default_fee_symbol(exchange)
314322
if symbol == default_fee_symbol:

0 commit comments

Comments
 (0)