[Devices] handle missing selected device error in copy trading

Author: Guillaume De Saint Martin

octobot/community/authentication.py

@@ -112,8 +112,11 @@ async def _ensure_init_community_feed(self):
             await self._community_feed.start()
 
     async def register_feed_callback(self, channel_type, callback, identifier=None):
-        await self._ensure_init_community_feed()
-        await self._community_feed.register_feed_callback(channel_type, callback, identifier=identifier)
+        try:
+            await self._ensure_init_community_feed()
+            await self._community_feed.register_feed_callback(channel_type, callback, identifier=identifier)
+        except errors.DeviceError as e:
+            self.logger.error(f"Impossible to connect to community signals: {e}")
 
     async def send(self, message, channel_type, identifier=None):
         """
@@ -230,7 +233,7 @@ async def update_selected_device(self):
         self.user_account.flush_device_details()
         await self._load_device_if_selected()
         if not self.user_account.has_selected_device_data():
-            self.logger.info("No selected device. Please select a device to enable your community features.")
+            self.logger.info(self.user_account.NO_SELECTED_DEVICE_DESC)
 
     async def _load_device_if_selected(self):
         # 1. use user selected device id if any

octobot/community/community_user_account.py

@@ -14,10 +14,13 @@
 #  You should have received a copy of the GNU General Public
 #  License along with OctoBot. If not, see <https://www.gnu.org/licenses/>.
 import octobot.community.community_supports as community_supports
+import octobot.community.errors as errors
 
 
 class CommunityUserAccount:
     USER_DATA_CONTENT = "content"
+    NO_SELECTED_DEVICE_DESC = "No selected device. Please select a device to enable your community features."
+
 
     def __init__(self):
         self.gql_user_id = None
@@ -51,7 +54,10 @@ def get_selected_device_raw_data(self):
         return self._selected_device_raw_data
 
     def get_selected_device_uuid(self):
-        return self.get_selected_device_raw_data().get("uuid", None)
+        try:
+            return self.get_selected_device_raw_data().get("uuid", None)
+        except AttributeError:
+            raise errors.DeviceError(self.NO_SELECTED_DEVICE_DESC)
 
     @staticmethod
     def get_device_id(device):