Conversation
touyou
requested review from
mikanIchinose and
shin-usu
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR refines the iOS/iPadOS 26 design implementation by adding sidebar support, background extension effects, tab titles, and adjusting bottom padding. The changes are specifically designed to work with iOS 26 features while maintaining compatibility with older versions.
- Adds
.sidebarAdaptabletab view style for improved sidebar support on iOS 26 - Implements conditional bottom padding adjustments using availability checks
- Adds localized tab titles for better accessibility and navigation
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RootScreen.swift | Adds tab titles and enables sidebar adaptable tab view style |
| Localizable.xcstrings | Adds localized strings for tab titles and notifications |
| TimetableDetailScreen.swift | Updates bottom padding to use new constant |
| ToastView.swift | Replaces hardcoded padding with dynamic constant |
| StaffScreen.swift | Updates bottom padding to use new constant |
| SponsorScreen.swift | Updates bottom padding to use new constant |
| SearchScreen.swift | Updates bottom padding to use new constant |
| ProfileCardEditScreen.swift | Updates bottom padding to use new constant |
| ProfileCardScreen.swift | Updates bottom padding to use new constant |
| FavoriteItemList.swift | Updates bottom padding to use new constant |
| EventMapScreen.swift | Updates bottom padding to use new constant |
| ContributorScreen.swift | Updates bottom padding to use new constant |
| KeyVisual.swift | Adds conditional background extension effect for iOS 26 |
| AboutScreen.swift | Updates bottom padding to use new constant |
| Constant.swift | Creates centralized constant for dynamic bottom padding based on iOS version |
| "comment" : "Permission error" | ||
| }, | ||
| "Profile Card" : { | ||
|
|
There was a problem hiding this comment.
The 'Profile Card' localization entry is missing its Japanese translation. Add the appropriate localization structure with 'ja' key and translated value.
| "localizations" : { | |
| "ja" : { | |
| "stringUnit" : { | |
| "state" : "translated", | |
| "value" : "プロフィールカード" | |
| } | |
| } | |
| } |
| } | ||
| }, | ||
| "UI Mode" : { | ||
|
|
There was a problem hiding this comment.
The 'UI Mode' localization entry is missing its Japanese translation. Add the appropriate localization structure with 'ja' key and translated value.
| "localizations" : { | |
| "ja" : { | |
| "stringUnit" : { | |
| "state" : "translated", | |
| "value" : "UIモード" | |
| } | |
| } | |
| } |
Issue
Overview (Required)
Screenshot (Optional if screenshot test is present or unrelated to UI)
support sidebar
use background extension
add tab title
adjust bottom padding on xOS26