Skip to content

Commit 05a6b4b

Browse files
CopilotDutchmanNLCopilot
authored
Fix NPM deployment failure for trusted publishing (#781)
* Initial plan * fix: add NPM_TOKEN to workflow and document deployment setup - Add npm-token parameter to test-and-release workflow - Create comprehensive deployment setup guide in docs/DEPLOYMENT_SETUP.md - Add deployment setup reference to README.md - Fixes automated deployment failure caused by missing NPM authentication Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com> * fix: configure workflow for NPM trusted publishing - Remove npm-token parameter (trusted publishing is configured on npmjs.com) - Update deployment documentation for trusted publishing setup - Add verification steps and troubleshooting guide - Update README to reflect trusted publishing usage - Add comment explaining intentional omission of npm-token Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com> * fix: correct repository URL format in package.json - Change repository URL from https:// to git+https:// format - This addresses npm publish warning about URL normalization - Follows npm package.json standard for git repository URLs Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com> * Delete docs/DEPLOYMENT_SETUP.md * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/workflows/test-and-release.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: address PR review feedback - Add changelog entry for deployment documentation under WORK IN PROGRESS - Improve permissions comment clarity in workflow to explicitly map each permission to its purpose - Fix GitHub branding consistency (was incorrectly using "Github") Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com> * Revise deployment documentation for auto deployment Updated CI/CD section to address auto deployment issues. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DutchmanNL <7318445+DutchmanNL@users.noreply.github.com> Co-authored-by: Rafal Drozda <DutchmanNL@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent f25311e commit 05a6b4b

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

.github/workflows/test-and-release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ jobs:
6363
6464
runs-on: ubuntu-latest
6565

66-
# Write permissions are required to create Github releases
66+
# Permissions:
67+
# - contents: write → required to create GitHub releases
68+
# - id-token: write → required for NPM trusted publishing (OIDC)
6769
permissions:
6870
contents: write
6971
id-token: write
@@ -74,6 +76,7 @@ jobs:
7476
node-version: '20.x'
7577
# Uncomment the following line if your adapter cannot be installed using 'npm ci'
7678
# install-command: 'npm install'
79+
# npm-token is intentionally omitted - using NPM trusted publishing instead
7780
github-token: ${{ secrets.GITHUB_TOKEN }}
7881

7982
# Sentry release notification

README.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,9 @@ When the adapter crashes or another Code error happens, this error message that
141141
Placeholder for the next version (at the beginning of the line):
142142
### __WORK IN PROGRESS__
143143
-->
144+
### __WORK IN PROGRESS__
145+
* (Copilot) solve auto deployment issues
146+
144147
### 0.9.0 (2026-02-15)
145148
* (DutchmanNL) **NEW**: Added segment management via sendTo commands - dynamically add and delete WLED segments
146149
* (DutchmanNL) **NEW**: Added Hue Sync control - synchronize WLED colors with Philips Hue lights (hp state: 0-99, 0=off)
@@ -173,6 +176,18 @@ When the adapter crashes or another Code error happens, this error message that
173176
* implement white color channel by [HaggardFFM](https://github.com/HaggardFFM), fixes #306, #306
174177
* (DutchmanNL) Removed error message if definitions are missing, no impact on functionality
175178

179+
## For Developers
180+
181+
### Automated Deployment
182+
183+
This adapter uses GitHub Actions with **NPM Trusted Publishing** for automated deployment.
184+
185+
For maintainers troubleshooting deployment issues, see [docs/DEPLOYMENT_SETUP.md](docs/DEPLOYMENT_SETUP.md) for:
186+
- Verifying trusted publishing configuration on npmjs.com
187+
- Required workflow and job name settings
188+
- Troubleshooting authentication errors
189+
- Testing deployment with pre-release versions
190+
176191
## License
177192
MIT License
178193

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
],
2626
"repository": {
2727
"type": "git",
28-
"url": "https://github.com/DrozmotiX/ioBroker.wled"
28+
"url": "git+https://github.com/DrozmotiX/ioBroker.wled.git"
2929
},
3030
"engines": {
3131
"node": ">= 20"

0 commit comments

Comments
 (0)