-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Description
I suggest a range of minor improvements to the current version of the InfluenceCalculator class:
- Add
count_thresh=5argument to__init__that in turn is provided to_load_sql_datato support customized thresholds on the synapse counts. - Clarify in docstring possible values to
syn_weight_measureargument of_create_sparse_Wmethod. - Clarify in docstring that the
silenced_neuronsargument of thecalculate_influencemethod needs to be a list or numpy array ofneuron_idsrather than a pandas table, and update the usage example accordingly. - Eventually turn the
_solve_lin_systemmethod into a static method, as it doesn't seem to modify any class variables. - Ensure that the
_normalize_Wmethod directly modifiesW_norm, such that it doesn't need to be returned, and thatW_norm = self._normalize_W(W_norm)can be replaced by a simple call toself._normalize_W(W_norm). - To clarify that the
_set_columns_to_zeroexpectssilenced_neuronsto be W matrix indices rather thanneuron_ids, rename argument tosilenced_W_idcsand update the method's docstring to reflect that.
Metadata
Metadata
Assignees
Labels
No labels