refactor: added validate_credentials

Author: Leechael

custom-domain/dstack-ingress/scripts/certman.py

@@ -10,6 +10,7 @@
 # Add script directory to path to import dns_providers
 sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))
 
+from .dns_providers.base import DNSProvider
 from dns_providers import DNSProviderFactory
 
 
@@ -238,27 +239,6 @@ def _debug_plugin_registration(self) -> None:
         except Exception as debug_error:
             print(f"Debug failed: {debug_error}")
 
-    def _validate_provider_credentials(self) -> bool:
-        """Validate provider credentials by testing API access."""
-        print(f"Validating {self.provider_type} API credentials...")
-        
-        try:
-            # For Namecheap, test API access
-            if hasattr(self.provider, '_make_request'):
-                test_result = self.provider._make_request("namecheap.users.getBalances")
-                if test_result.get("success", False):
-                    print(f"✓ {self.provider_type} API credentials are valid")
-                    return True
-                else:
-                    print(f"✗ {self.provider_type} API validation failed: {test_result.get('errors', ['Unknown error'])}")
-                    return False
-            else:
-                print(f"No API validation available for {self.provider_type}, skipping")
-                return True
-        except Exception as e:
-            print(f"Error validating {self.provider_type} credentials: {e}")
-            return False
-    
     def setup_credentials(self) -> bool:
         """Setup credentials file for certbot using provider implementation."""
         result = self.provider.setup_certbot_credentials()
@@ -304,7 +284,7 @@ def obtain_certificate(self, domain: str, email: str) -> bool:
             return False
 
         # Validate credentials before proceeding
-        if not self._validate_provider_credentials():
+        if not self.provider.validate_credentials():
             print(f"Failed to validate credentials for {self.provider_type}", file=sys.stderr)
             return False
 

custom-domain/dstack-ingress/scripts/dns_providers/base.py

@@ -52,6 +52,7 @@ class DNSProvider(ABC):
 
     # Certbot configuration - override in subclasses
     CERTBOT_PLUGIN = ""
+    CERTBOT_PLUGIN_MODULE = ""
     CERTBOT_PACKAGE = ""
     CERTBOT_PROPAGATION_SECONDS = 120
     CERTBOT_CREDENTIALS_FILE = ""  # Path to credentials file
@@ -64,6 +65,10 @@ def setup_certbot_credentials(self) -> bool:
         """Setup credentials file for certbot. Override in subclasses if needed."""
         return True  # Default: no setup needed
 
+    def validate_credentials(self) -> bool:
+        """Validate provider credentials. Override in subclasses if needed."""
+        return True  # Default: no validation needed
+
     @classmethod
     def suitable(cls) -> bool:
         """Check if the current environment is suitable for this DNS provider."""

custom-domain/dstack-ingress/scripts/dns_providers/namecheap.py

@@ -52,6 +52,23 @@ def setup_certbot_credentials(self) -> bool:
             print(f"Error setting up credentials file: {e}")
             return False
 
+    def validate_credentials(self) -> bool:
+        """Validate Namecheap API credentials by testing API access."""
+        print(f"Validating Namecheap API credentials...")
+        
+        try:
+            # Test API access with getBalances command
+            test_result = self._make_request("namecheap.users.getBalances")
+            if test_result.get("success", False):
+                print(f"✓ Namecheap API credentials are valid")
+                return True
+            else:
+                print(f"✗ Namecheap API validation failed: {test_result.get('errors', ['Unknown error'])}")
+                return False
+        except Exception as e:
+            print(f"Error validating Namecheap credentials: {e}")
+            return False
+
     def _make_request(self, command: str, **params) -> Dict:
         """Make a request to the Namecheap API with error handling."""
         # Base parameters required for all Namecheap API calls