Skip to content

Commit 75f5bae

Browse files
Leechaelclaude
andcommitted
fix: restore correct namecheap plugin name and add plugin verification
- Change CERTBOT_PLUGIN back to 'dns-namecheap' (correct value) - Add plugin verification after installation to ensure certbot recognizes it - This helps troubleshoot plugin recognition issues in Docker environment 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent d7f748f commit 75f5bae

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

custom-domain/dstack-ingress/scripts/certman.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,15 @@ def install_plugin(self) -> bool:
4545
print(f"Failed to install plugin: {result.stderr}", file=sys.stderr)
4646
return False
4747
print(f"Successfully installed {self.provider.CERTBOT_PACKAGE}")
48+
49+
# Verify plugin is recognized by certbot
50+
verify_cmd = ["certbot", "plugins"]
51+
verify_result = subprocess.run(verify_cmd, capture_output=True, text=True)
52+
if self.provider.CERTBOT_PLUGIN not in verify_result.stdout:
53+
print(f"Warning: Plugin {self.provider.CERTBOT_PLUGIN} not recognized by certbot after installation", file=sys.stderr)
54+
print(f"Available plugins: {verify_result.stdout}", file=sys.stderr)
55+
return False
56+
4857
return True
4958
except Exception as e:
5059
print(f"Error installing plugin: {e}", file=sys.stderr)

custom-domain/dstack-ingress/scripts/dns_providers/namecheap.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class NamecheapDNSProvider(DNSProvider):
1111
"""Namecheap DNS provider implementation."""
1212

1313
DETECT_ENV = "NAMECHEAP_API_KEY"
14-
CERTBOT_PLUGIN = "namecheap"
14+
CERTBOT_PLUGIN = "dns-namecheap"
1515
CERTBOT_PACKAGE = "certbot-dns-namecheap"
1616
CERTBOT_PROPAGATION_SECONDS = 120
1717
CERTBOT_CREDENTIALS_FILE = "~/.namecheap/namecheap.ini"

0 commit comments

Comments
 (0)