fix

Author: Leechael

custom-domain/dstack-ingress/scripts/certman.py

@@ -63,13 +63,25 @@ def install_plugin(self) -> bool:
                     print(f"Plugin {self.provider.CERTBOT_PLUGIN} successfully imported")
 
                     # Try to create a simple test to see if the plugin works
+                    print(f"Testing if plugin {self.provider.CERTBOT_PLUGIN} is available...")
                     test_cmd = ["certbot", "plugins"]
                     test_result = subprocess.run(test_cmd, capture_output=True, text=True, timeout=10)
+                    
+                    print(f"Certbot plugins command returned: {test_result.returncode}")
+                    if test_result.stdout:
+                        print(f"Available plugins:")
+                        print(test_result.stdout)
+                    
+                    if test_result.stderr:
+                        print(f"Plugin test stderr: {test_result.stderr}")
+                    
                     if test_result.returncode == 0 and "dns-namecheap" in test_result.stdout:
-                        print(f"Plugin {self.provider.CERTBOT_PLUGIN} is working correctly")
+                        print(f"Plugin {self.provider.CERTBOT_PLUGIN} is available and working correctly")
                         return True
                     else:
-                        print(f"Plugin {self.provider.CERTBOT_PLUGIN} test failed: {test_result.stderr}")
+                        print(f"Plugin {self.provider.CERTBOT_PLUGIN} may not be properly installed")
+                        if "dns-namecheap" not in test_result.stdout:
+                            print(f"Warning: dns-namecheap plugin not found in certbot plugins list")
                         # In Docker environments, this might still work in practice
                         print("Continuing anyway - plugin may work in actual certbot execution")
                         return True
@@ -114,6 +126,7 @@ def _build_certbot_command(self, action: str, domain: str, email: str) -> List[s
             [
                 "-a", plugin,
                 "--non-interactive",
+                "-v",  # Add verbose flag for detailed output
             ]
         )
         print(f"Added plugin and non-interactive flags")
@@ -162,6 +175,17 @@ def obtain_certificate(self, domain: str, email: str) -> bool:
             return False
         print(f"Credentials setup completed")
 
+        # Check certbot version for debugging
+        try:
+            version_cmd = ["certbot", "--version"]
+            version_result = subprocess.run(version_cmd, capture_output=True, text=True, timeout=10)
+            if version_result.returncode == 0:
+                print(f"Certbot version: {version_result.stdout.strip()}")
+            else:
+                print(f"Could not determine certbot version")
+        except Exception as e:
+            print(f"Error checking certbot version: {e}")
+        
         cmd = self._build_certbot_command("certonly", domain, email)
         print(f"Executing certbot command...")
 
@@ -170,15 +194,20 @@ def obtain_certificate(self, domain: str, email: str) -> bool:
 
             print(f"Certbot command completed with return code: {result.returncode}")
 
-            if result.stdout:
-                print(f"Certbot stdout: {result.stdout}")
+            # Always print stdout if available
+            if result.stdout.strip():
+                print(f"=== Certbot stdout ===")
+                print(result.stdout)
+                print(f"=== End stdout ===")
+            
+            # Always print stderr if available
+            if result.stderr.strip():
+                print(f"=== Certbot stderr ===", file=sys.stderr)
+                print(result.stderr, file=sys.stderr)
+                print(f"=== End stderr ===", file=sys.stderr)
 
             if result.returncode != 0:
                 print(f"Certificate obtaining failed with return code {result.returncode}")
-                if result.stderr:
-                    print(f"Certificate obtaining failed: {result.stderr}", file=sys.stderr)
-                if result.stdout:
-                    print(f"Certificate stdout on failure: {result.stdout}", file=sys.stderr)
                 return False
 
             print(f"Certificate obtained successfully for {domain}")