Skip to content

Commit 1324177

Browse files
h4x3rotabclaude
andcommitted
Clean up test suite - remove duplicate upgrade tests
- Remove Upgrades.t.sol (duplicate functionality) - Remove UpgradesBasic.t.sol (only using plugin-based upgrades) - Keep UpgradesWithPlugin.t.sol as the comprehensive upgrade test suite - Update README documentation to reflect simplified test structure - Maintain 27/27 core functionality tests passing This streamlines the test suite by keeping only the most comprehensive upgrade tests that use the OpenZeppelin Foundry Upgrades plugin. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 549476e commit 1324177

File tree

3 files changed

+6
-314
lines changed

3 files changed

+6
-314
lines changed

kms/auth-eth/README.md

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -54,35 +54,28 @@ forge test --ffi --match-path "test/DstackApp.t.sol" && forge test --ffi --match
5454

5555
### Upgrade Tests
5656

57-
Test upgrade functionality and contract migration scenarios:
57+
Test upgrade functionality and contract migration scenarios using OpenZeppelin Foundry Upgrades plugin:
5858

5959
```bash
60-
# Test basic upgrade functionality (5 tests)
61-
forge test --ffi --match-path "test/UpgradesBasic.t.sol"
62-
63-
# Test advanced upgrade scenarios (may have OpenZeppelin validation issues)
64-
forge test --ffi --match-path "test/Upgrades.t.sol"
60+
# Test comprehensive upgrade scenarios with plugin (may have OpenZeppelin validation issues)
6561
forge test --ffi --match-path "test/UpgradesWithPlugin.t.sol"
6662
```
6763

6864
### Run All Working Tests
6965

7066
```bash
71-
# Run all stable tests (32 tests total)
67+
# Run all stable tests (27 tests total)
7268
forge test --ffi --match-path "test/DstackApp.t.sol" && \
73-
forge test --ffi --match-path "test/DstackKms.t.sol" && \
74-
forge test --ffi --match-path "test/UpgradesBasic.t.sol"
69+
forge test --ffi --match-path "test/DstackKms.t.sol"
7570
```
7671

7772
### Test Coverage Summary
7873

7974
-**DstackApp.t.sol**: 11/11 tests PASS - Core app functionality
8075
-**DstackKms.t.sol**: 16/16 tests PASS - Core KMS functionality
81-
-**UpgradesBasic.t.sol**: 5/5 tests PASS - Basic upgrade functionality
82-
- ⚠️ **Upgrades.t.sol**: OpenZeppelin validation issues (advanced upgrade testing)
83-
- ⚠️ **UpgradesWithPlugin.t.sol**: OpenZeppelin validation issues (advanced upgrade testing)
76+
- ⚠️ **UpgradesWithPlugin.t.sol**: OpenZeppelin validation issues (comprehensive plugin-based upgrade testing)
8477

85-
**Total: 32/32 core and basic upgrade tests PASSING**
78+
**Total: 27/27 core functionality tests PASSING**
8679

8780
## Important Notes
8881

kms/auth-eth/test/Upgrades.t.sol

Lines changed: 0 additions & 147 deletions
This file was deleted.

kms/auth-eth/test/UpgradesBasic.t.sol

Lines changed: 0 additions & 154 deletions
This file was deleted.

0 commit comments

Comments
 (0)