Use or_panic instead of expect

Author: kvinwang

.github/workflows/rust.yml

@@ -25,7 +25,7 @@ jobs:
         components: clippy, rustfmt
 
     - name: Run Clippy
-      run: cargo clippy -- -D warnings --allow unused_variables
+      run: cargo clippy -- -D warnings -D clippy::expect_used -D clippy::unwrap_used --allow unused_variables
 
     - name: Cargo fmt check
       run: cargo fmt --check --all

Cargo.lock

@@ -86,6 +86,7 @@ size-parser = { path = "size-parser" }
 
 # Core dependencies
 anyhow = { version = "1.0.97", default-features = false }
+or-panic = { version = "1.0", default-features = false }
 chrono = "0.4.40"
 clap = { version = "4.5.32", features = ["derive", "string"] }
 dashmap = "6.1.0"

Cargo.toml

@@ -24,3 +24,4 @@ tokio = { workspace = true, features = ["full"] }
 toml_edit.workspace = true
 tracing-subscriber.workspace = true
 rustls.workspace = true
+or-panic.workspace = true

certbot/cli/Cargo.toml

@@ -10,6 +10,7 @@ use certbot::{CertBotConfig, WorkDir};
 use clap::Parser;
 use documented::DocumentedFields;
 use fs_err as fs;
+use or_panic::ResultOrPanic;
 use serde::{Deserialize, Serialize};
 use toml_edit::ser::to_document;
 
@@ -166,7 +167,7 @@ async fn main() -> Result<()> {
     }
     rustls::crypto::ring::default_provider()
         .install_default()
-        .expect("Failed to install default crypto provider");
+        .or_panic("Failed to install default crypto provider");
 
     let args = Args::parse();
     match args.command {

certbot/cli/src/main.rs

@@ -7,6 +7,7 @@
 
 use anyhow::{bail, Context, Result};
 use log::debug;
+use scale::Decode;
 
 use crate::Machine;
 
@@ -392,6 +393,13 @@ fn qemu_loader_append(data: &mut Vec<u8>, cmd: LoaderCmd) {
     }
 }
 
+/// ACPI table header (first 8 bytes of every ACPI table)
+#[derive(Debug, Decode)]
+struct AcpiTableHeader {
+    signature: [u8; 4],
+    length: u32,
+}
+
 /// Searches for an ACPI table with the given signature and returns its offset,
 /// checksum offset, and length.
 fn find_acpi_table(tables: &[u8], signature: &str) -> Result<(u32, u32, u32)> {
@@ -407,24 +415,21 @@ fn find_acpi_table(tables: &[u8], signature: &str) -> Result<(u32, u32, u32)> {
             bail!("Table not found: {signature}");
         }
 
-        let tbl_sig = &tables[offset..offset + 4];
-        let tbl_len_bytes: [u8; 4] = tables[offset + 4..offset + 8]
-            .try_into()
-            .expect("header len checked");
-        let tbl_len = u32::from_le_bytes(tbl_len_bytes) as usize;
+        let header = AcpiTableHeader::decode(&mut &tables[offset..])
+            .context("failed to decode ACPI table header")?;
 
-        if tbl_sig == sig_bytes {
+        if header.signature == sig_bytes {
             // Found the table
-            return Ok((offset as u32, (offset + 9) as u32, tbl_len as u32));
+            return Ok((offset as u32, (offset + 9) as u32, header.length));
         }
 
-        if tbl_len == 0 {
+        if header.length == 0 {
             // Invalid table length, stop searching
-            bail!("Found table with zero length at offset {offset}");
+            bail!("found table with zero length at offset {offset}");
         }
         // Move to the next table
-        offset += tbl_len;
+        offset += header.length as usize;
     }
 
-    bail!("Table not found: {signature}");
+    bail!("table not found: {signature}");
 }

dstack-mr/src/acpi.rs

@@ -341,7 +341,7 @@ impl<'a> Tdvf<'a> {
             td_hob.extend_from_slice(&length.to_le_bytes());
         };
 
-        let (_, last_start, last_end) = memory_acceptor.ranges.pop().expect("No ranges");
+        let (_, last_start, last_end) = memory_acceptor.ranges.pop().context("No ranges")?;
 
         for (accepted, start, end) in memory_acceptor.ranges {
             if end < start {

dstack-mr/src/tdvf.rs

@@ -50,6 +50,7 @@ reqwest = { workspace = true, features = ["json"] }
 hyper = { workspace = true, features = ["server", "http1"] }
 hyper-util = { version = "0.1", features = ["tokio"] }
 jemallocator.workspace = true
+or-panic.workspace = true
 
 [target.'cfg(unix)'.dependencies]
 nix = { workspace = true, features = ["resource"] }

gateway/Cargo.toml

@@ -2,6 +2,8 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(clippy::expect_used)]
+
 fn main() {
     prpc_build::configure()
         .out_dir(std::env::var_os("OUT_DIR").expect("OUT_DIR not set"))

gateway/rpc/build.rs

@@ -167,7 +167,8 @@ async fn main() -> Result<()> {
     info!("Starting background tasks");
     state.start_bg_tasks().await?;
     state.lock().reconfigure()?;
-    proxy::start(proxy_config, state.clone());
+
+    proxy::start(proxy_config, state.clone()).context("failed to start the proxy")?;
 
     let admin_figment =
         Figment::new()